Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Uncheck group limit in admin settings #3758

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix: Uncheck group limit in admin settings #3758

merged 3 commits into from
Jun 14, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jun 12, 2024 •
edited
Loading

Summary

Previously, trying to uncheck the checkbox would simply re-enable it automatically. This PR fixes this issue. Also adds an inputLabel prop to the NcSelect so it doesn't error anymore (and accessibility reasons :D)

uncheck-group-limit-richdouments-fix.mp4

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added bug Something isn't working 3. to review Ready to be reviewed regression labels Jun 12, 2024
@elzody elzody self-assigned this Jun 12, 2024
@elzody elzody marked this pull request as draft June 12, 2024 18:05
@elzody
fix: Uncheck group limit settings
a9bc601 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody
fix: Add input label to NcSelect
13d6a38 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody marked this pull request as ready for review June 12, 2024 20:08
@juliushaertl
Copy link
Member

Thanks for looking into this. We used to hide the select if the box was unchecked. Maybe we can bring back this behaviour as well?

jancborchardt
jancborchardt reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have only the same feedback as Julius about hiding the dropdown. :)

@elzody
fix: Hide NcSelect when unchecked
58a448c 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@juliushaertl juliushaertl merged commit 7d70c86 into main Jun 14, 2024
47 of 49 checks passed
@juliushaertl
Copy link
Member

/backport to stable29

@juliushaertl
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jun 14, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jun 14, 2024
Merged
3 tasks
@juliushaertl
Copy link
Member

Quick tip: Feel free to already comment with the backport requests when opening the PR, that way the backports will get scheduled once merged. Makes it a bit easier to not miss them :)

@jancborchardt jancborchardt deleted the fix/remove-group-limit branch June 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@juliushaertl juliushaertl juliushaertl approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@elzody elzody

Labels
3. to review Ready to be reviewed bug Something isn't working regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to uncheck 'restrict usage/edit to specific groups' in Nextcloud Admin Settings
3 participants
@elzody @juliushaertl @jancborchardt