Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make built-in code server setup more stable #3762

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 13, 2024

Best to be reviewed as individual commits for the frontend, backend changes are mostly moving code and adding proper status codes

  • chore: Refactor frontend capabilities to a service to be able to update on the fly
  • fix: Move auto setup of built-in code server to an async request done by the frontend
  • Add typescript support for eslint and fix errors

Can be tested with:

  • occ app:enable richdocumentscode
  • occ config:app:delete richdocuments wopi_url
  • Reload the file list
  • Now a request happens that autoconfigures the built-in code server (if you are admin and it is not configured yet)
  • Once succeeded it will update the capabilities in the frontend which makes the viewer work

Fixes #1282

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Jun 13, 2024
@juliushaertl juliushaertl added this to the Nextcloud 30 milestone Jun 13, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the error

Property oc_isadmin does not exist on type Window & typeof globalThis

Not sure about it

…te on the fly

Signed-off-by: Julius Härtl <jus@bitgrid.net>
… by the frontend

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

Fixed, I missed to add the types file for those

@juliushaertl juliushaertl requested a review from elzody June 14, 2024 08:50
@juliushaertl juliushaertl merged commit 5b3dbf3 into main Jun 20, 2024
58 of 60 checks passed
@juliushaertl juliushaertl deleted the fix/code-autosetup-async branch June 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichDocuments built-in CODE causes significant slowdown/timeout issues
2 participants