Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid background fetch if not configured #3790

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: Avoid background fetch if not configured #3790

merged 1 commit into from
Jun 24, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 24, 2024 •
edited
Loading

Fix #3788

Avoid sending requests that fail later on if no URL is configured

@juliushaertl
fix: Avoid background fetch if not configured
a9c36fd 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl mentioned this pull request Jun 24, 2024
Closed
8 tasks
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Jun 24, 2024
@juliushaertl juliushaertl merged commit 948900c into main Jun 24, 2024
56 checks passed
@juliushaertl juliushaertl deleted the fix/3788 branch June 24, 2024 14:03
@juliushaertl
Copy link
Member Author

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: OC\\Http\\Client\\Client::get(): Argument #1 ($uri) must be of type string, null given
2 participants
@juliushaertl @elzody