fix(client): Use shared default options for HTTP client requests #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/harmonize_client_options
branch
from
9532339
to
a72bbf3
Compare
|
/backport to stable29 |
|
/backport to stable28 |
Makes sure we always set a sane timeout and `allow_local_address`. Fixes: #3255 Fixes: #3435 Fixes: nextcloud/server#44190 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/harmonize_client_options
branch
from
a72bbf3
to
00f61ba
Compare
juliushaertl
approved these changes
Jul 25, 2024
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/3831/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00f61ba7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3831/stable28Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@mejo- Can you take care of the manual backport for 28? |
|
Manual backport for 28: #3993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure we always set a sane timeout and
allow_local_address.Fixes: #3255
Fixes: #3435
Fixes: nextcloud/server#44190
Checklist