Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guest username not picked up the second time loading a share link #3907

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Aug 14, 2024

Summary

This PR updates the @nextcloud/auth version in use by richdocuments in order to take advantage of the getGuestnickname and setGuestNickname methods introduced, which use local browser storage rather than a cookie to set the guest nickname.

I think the issue previously was that the cookie with the guest name was set, but it wasn't read again and used, thus only being used on the first time the user is asked. But now it's fixed, and does not use a cookie anymore.

As far as I can tell, it does not require any back-end change.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody self-assigned this Aug 14, 2024
@elzody elzody added bug Something isn't working 2. developing Work in progress javascript Pull requests that update Javascript code regression labels Aug 14, 2024
@elzody elzody changed the title Fix/guest username fix: guest username not picked up the second time loading a share link Aug 14, 2024
@elzody elzody marked this pull request as ready for review August 14, 2024 16:33
@elzody elzody added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Aug 14, 2024
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yes backend wise passing the guestName over with the request to generate the token is enough as it gets set by that then

$this->tokenManager->setGuestName($wopi, $guestName);

@elzody
Copy link
Contributor Author

elzody commented Aug 14, 2024

/backport to stable30

@elzody
Copy link
Contributor Author

elzody commented Aug 14, 2024

/backport to stable29

@elzody
Copy link
Contributor Author

elzody commented Aug 14, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working javascript Pull requests that update Javascript code regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guest name is not picked up the second time loading a share link
2 participants