fix: guest username not picked up the second time loading a share link #3907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
@nextcloud/auth
version in use by richdocuments in order to take advantage of thegetGuestnickname
andsetGuestNickname
methods introduced, which use local browser storage rather than a cookie to set the guest nickname.I think the issue previously was that the cookie with the guest name was set, but it wasn't read again and used, thus only being used on the first time the user is asked. But now it's fixed, and does not use a cookie anymore.
As far as I can tell, it does not require any back-end change.
Checklist