Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): checkbox field type #47290

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Aug 16, 2024

Summary

This PR will introduce a checkbox type when filling templates.
Part of nextcloud/richdocuments#3917

2024-08-26.13-01-49.mp4

Note

Tests are implemented from the richdocuments side: nextcloud/richdocuments#3919

Checklist

@elzody elzody added enhancement 2. developing Work in progress javascript php Pull requests that update Php code feature: templates labels Aug 16, 2024
@elzody elzody self-assigned this Aug 16, 2024
@elzody elzody force-pushed the feat/checkbox-template-field-type branch from d9995e1 to 494bf61 Compare August 16, 2024 20:43
@elzody elzody changed the title Checkbox template field type feat(templates): checkbox field type Aug 20, 2024
@elzody elzody added the design Design, UI, UX, etc. label Aug 20, 2024
@elzody elzody force-pushed the feat/checkbox-template-field-type branch from e226009 to cff52d9 Compare August 20, 2024 17:25
@elzody elzody marked this pull request as ready for review August 20, 2024 17:25
@elzody elzody requested a review from skjnldsv as a code owner August 20, 2024 17:25
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 20, 2024
jancborchardt

This comment was marked as resolved.

@elzody

This comment was marked as resolved.

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, just some small comments

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice design-wise! :)

@elzody elzody force-pushed the feat/checkbox-template-field-type branch from 16f9565 to c0c6e6a Compare August 27, 2024 14:46
@elzody elzody modified the milestones: Nextcloud 31, Nextcloud 30 Aug 27, 2024
@elzody
Copy link
Contributor Author

elzody commented Aug 27, 2024

/backport to stable30

@@ -29,11 +26,12 @@
</NcModal>
</template>

<script lang="ts">
<script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why reverting to JS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't using TypeScript in this file, but if it makes it more consistent with the rest of the files I can leave it as TS.

@elzody elzody disabled auto-merge August 27, 2024 16:44
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the feat/checkbox-template-field-type branch from 9ba3f16 to a82a542 Compare August 27, 2024 18:44
@elzody elzody merged commit a740e60 into master Aug 27, 2024
171 checks passed
@elzody elzody deleted the feat/checkbox-template-field-type branch August 27, 2024 20:15

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress backport-request design Design, UI, UX, etc. enhancement feature: templates javascript php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants