Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: datavzrd #5882

Closed
wants to merge 4 commits into from
Closed

new module: datavzrd #5882

wants to merge 4 commits into from

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Jun 25, 2024 •
edited
Loading

PR checklist

Closes #2511

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@vickylaram I will try and finish the module as I want to use it in the variantbenchmarking pipeline. I hope thats ok for you!

@famosab famosab requested a review from a team as a code owner June 25, 2024 09:13
@famosab famosab requested review from kpadm and removed request for a team June 25, 2024 09:13
This was referenced Jun 25, 2024
Merged
Merged
@famosab
Copy link
Contributor Author

famosab commented Jun 25, 2024

Closed for #5883

@famosab famosab closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpadm kpadm Awaiting requested review from kpadm kpadm is a code owner automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: datavzrd
2 participants
@famosab @vickylaram