Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sentieon CI #5934

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Fix Sentieon CI #5934

merged 3 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. ci: Remove setting secrets in pytest-workflow

    @edmundmiller
    edmundmiller committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8d32584 View commit details
    Browse the repository at this point in the history

  2. ci: Add a longer note about conditionals 

    https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow
Secrets cannot be directly referenced in if: conditionals.
Instead, consider setting secrets as job-level environment variables, then referencing the environment variables to conditionally run steps in the job.
For more information, see "Contexts" and jobs.<job_id>.steps[*].if.
    @edmundmiller
    edmundmiller committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1c90924 View commit details
    Browse the repository at this point in the history

  3. ci: Check for secrets in env 

    Because if this is coming from a fork it will fail
    @edmundmiller
    edmundmiller committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    903ec1d View commit details
    Browse the repository at this point in the history