Add panel component #1012
Draft
Add panel component #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidhunter08 can you add some screenshots? |
Comment on lines
+27
to
+28
| background: $color_nhsuk-green; | ||
| border: $nhsuk-border-width-panel solid transparent; |
There was a problem hiding this comment.
I presume this is similar to the GOV.UK panel - we should double check this looks ok with changed / forced colours.
There was a problem hiding this comment.
Yeah that's taken from GOV. I'll check what it looks like with changed / forced colours.
| border: $nhsuk-border-width-panel solid transparent; | ||
| box-sizing: border-box; | ||
| color: $color_nhsuk-white; | ||
| padding: nhsuk-spacing(6) - $nhsuk-border-width-panel; |
There was a problem hiding this comment.
add comment for why this is different?
There was a problem hiding this comment.
Which bit @edwardhorsford ?
| padding: nhsuk-spacing(6) - $nhsuk-border-width-panel; | ||
|
|
||
| @include mq($until: tablet) { | ||
| padding: nhsuk-spacing(4) - $nhsuk-border-width-panel; |
There was a problem hiding this comment.
add comment for why this is differenet?
Font sizesAfter reviewing the panel font sizes, taking into consideration the proposed type scale updates, I've change the panel body font size to 24px(20px on mobile).
|
5 tasks
This was referenced Sep 19, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add panel component for use on confirmation pages.
Large screens
Small screens
Checklist