Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass additional props to ScrollView, fix circle proptypes #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

adbl
Copy link

@adbl adbl commented Jan 9, 2018

  • Passes any additional props down to the ScrollView. I needed this to add style and can add a special property for that if that's more appropriate, note that wrapperStyle didn't work in my case since I needed to set overflow: visible on the scrollview.
  • Fixes passing StyleSheet styles to the circle props without warnings.
  • Don't render items before onLayout. Fixes layout issue where flex text (sub) children would not wrap if they where first rendered without bounds.

Based on the fork in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants