Update results for 4th run #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first repro collates the necessary parts from `proptest-arbitrary` and `proptest` and reproduces faithfully the messages from the crater run. The second repro is a bit more minimal, while still behaving differently under AST borrowck, but partially automatically reduced to focus on one of the two identical errors.
lqd
force-pushed
the
proptest-arbitrary
branch
from
40b71bf
to
af44153
Compare
Sucessfully built in the 4th crater run
lqd
changed the title
lqd
changed the title
nikomatsakis
approved these changes
Sep 18, 2018
README.md
Outdated
| @@ -112,3 +112,4 @@ | |||
| [#53789]: https://github.com/rust-lang/rust/issues/53789 | |||
| [18]: https://play.rust-lang.org/?gist=c990af931ab56d93207efcade0ffd01b&version=nightly&mode=debug&edition=2015 | |||
| [19]: https://play.rust-lang.org/?gist=1f1d03d4f8280b8843594cba668c9db4&version=nightly&mode=debug&edition=2015 | |||
| [20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015 | |||
There was a problem hiding this comment.
see discussion on Zulip. The TL;DR:
- Diagnostics have an immediate problem of printing
'_but referencing'_2 - Plus the diagnostic is ungreat: it should talk about how
'1is local to the closure but escapes in the return type - The error itself seems unfortunate but basically correct
README.md
Outdated
| @@ -119,3 +120,6 @@ | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
| [21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015 | |||
| [22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015 | |||
| [23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015 | |||
There was a problem hiding this comment.
confirm, correct for us to error
README.md
Outdated
| @@ -119,3 +120,6 @@ | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
| [21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015 | |||
| [22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015 | |||
| [23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015 | |||
| [24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015 | |||
There was a problem hiding this comment.
confirm, error looks correct, though it is not rust-lang/rust#52059 — I'm not sure what AST bug this is. Looks like something to do with DerefMut...?
README.md
Outdated
| @@ -119,3 +120,6 @@ | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
| [21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015 | |||
| [22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015 | |||
| [23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015 | |||
| [24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015 | |||
| [25]: https://play.rust-lang.org/?gist=f16c92102d7c16ec4feda59814ba7cf9&version=nightly&mode=debug&edition=2015 | |||
README.md
Outdated
| @@ -123,3 +124,4 @@ | |||
| [23]: https://play.rust-lang.org/?gist=2869a3fead3981815e077700d68de8eb&version=nightly&mode=debug&edition=2015 | |||
| [24]: https://play.rust-lang.org/?gist=d404421b51edcb0c2d6fb700a313be95&version=nightly&mode=debug&edition=2015 | |||
| [25]: https://play.rust-lang.org/?gist=f16c92102d7c16ec4feda59814ba7cf9&version=nightly&mode=debug&edition=2015 | |||
| [26]: https://play.rust-lang.org/?gist=1ddf9aa2d1bc3e96066576c2b4b05df3&version=nightly&mode=debug&edition=2015 | |||
There was a problem hiding this comment.
confirm, probably rust-lang/rust#38899
README.md
Outdated
| @@ -113,3 +114,5 @@ | |||
| [18]: https://play.rust-lang.org/?gist=c990af931ab56d93207efcade0ffd01b&version=nightly&mode=debug&edition=2015 | |||
| [19]: https://play.rust-lang.org/?gist=1f1d03d4f8280b8843594cba668c9db4&version=nightly&mode=debug&edition=2015 | |||
| [20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015 | |||
| [chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
README.md
Outdated
| @@ -41,6 +40,7 @@ | |||
| | `ilp-packet` | 0.3.0 | F | [4][] | | FIXME: find an issue link | | |||
| | `jmespath-macros` | 0.1.1 | + | | | | | |||
| | `liner` | 0.4.4 | F | [17][] | | | | |||
| | `LocustDB` | c59429 | + | [11][] | [#53570][] | | | |||
README.md
Outdated
| @@ -116,3 +117,5 @@ | |||
| [20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015 | |||
| [chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
| [21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015 | |||
README.md
Outdated
| @@ -116,3 +117,5 @@ | |||
| [20]: https://play.rust-lang.org/?gist=c6a5e5dcf99e04855350770b62528486&version=nightly&mode=debug&edition=2015 | |||
| [chiisai]: https://crater-reports.s3.amazonaws.com/pr-53426-2/try%23e3ede4ae5297558caacf160ecf523f3a5759f682/reg/chiisai-0.1.6/log.txt | |||
| [#53432]: https://github.com/rust-lang/rust/issues/53432 | |||
| [21]: https://play.rust-lang.org/?gist=448e4a6646e0048b027b03f607a612dc&version=nightly&mode=debug&edition=2015 | |||
| [22]: https://play.rust-lang.org/?gist=b61db3de15c2c0716d76d7e5df9abb02&version=nightly&mode=debug&edition=2015 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proptest-arbitraryandproptestand reproduces faithfully the messages from the crater run.LocustDB:
Now builds successfully 🎉
pom:
added minimized repro, it also shows the diagnostics I was wondering about: is there no information on where the
'2region comes from ?chiisai and fred: known fixed-by-nll Bug: nested closure outlives borrowed value. rust-lang/rust#53432. fred has 2 repros, one more faithful to hyper/futures and one more minimal. There is no repro for chiisai, but it's clear it's the same issue/pattern of a
hyper-0.11.0server done with a closure.ocl and gluon_vm: look fixed-by-nll. guon has 3 repros, as there are different 3 errors.
added all the failing crates' logs, so this one commit kinds steps on the toes of everything else
Since I tend to lose the WIP notes/documents, here are: the one for the 3rd run and for the 4th run.