Fix issue 603 #630
Merged
Fix issue 603 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-deb must be moved to the production dependencies section in order to use it to produce packages without any dev-dependencies (otherwise it wouldn't be available to build the packages since that's done after the removal of the dev-dependencies). Eventually we should implement the proper fix (which means replacing node-deb with standard Debian tools to create packages).
To remove dev dependencies from the final packages, they need to be removed from the package creation process first. This commit does that by replacing gulp with an external script during that process.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (with one exception, see below) the issue described in #603.
To fix #603, the way packages were created suffered an important change: before all the preparation/copy of files for the package was done via
gulp, but sincegulpitself is a dev dependency, this wouldn't work once the dev dependencies were removed from the package creation process, so now all that was previously done at thegulplevel is done with a new shell script (and since a shell script is more flexible, I included what was previously done viapackage.json's scripts so that the whole package building process is done in one step and within only that bash script).There was one other dev dependency that is used for package creation: node-deb, since this one would require a very big effort to replace, I'm moving it to be a non-dev dependency (it is still a good trade-off since
node-debis tiny and the rest of the dev dependencies are huge) but it should be replaced at some point (I've created issue #629 so that we don't forget).