Allow getting BTC address for an account when requesting a NIM address #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
soeren/choose-btc-address
branch
from
7cf2627
to
7b09ac1
Compare
mraveux
approved these changes
Mar 3, 2021
- Fix import order to avoid webpack warnings about conflicting import order between chunks choose-address, sign-btc-transaction, sign-btc-transaction-ledger, activate-btc, swap, swap-ledger, refund-swap-ledger, add-account, add-ledger - Ensure parsing of ChooseAddressRequest into expected types - Use State constant - await WalletStore.put - Fix address index off-by-one error
danimoh
force-pushed
the
soeren/choose-btc-address
branch
from
76abcf5
to
990b0be
Compare
danimoh
approved these changes
Mar 4, 2021
Comment on lines
+90
to
+93
| // const startIndex = Math.max(Math.min( | ||
| // walletInfo.btcAddresses.external.findIndex((addressInfo) => !addressInfo.used), | ||
| // walletInfo.btcAddresses.internal.findIndex((addressInfo) => !addressInfo.used), | ||
| // ), 0); |
There was a problem hiding this comment.
Not scanning all addresses again would indeed be good.
The current implementation tries to fill gaps between used addresses, which is good and wouldn't be accomplished by just using the start index of the last used address.
However, scanning could start at the last known, gap-less used address for internal and external addresses or even better just re-scan only the known, unused addresses for whether they have been used in the meantime and start scanning at the last known address only if then still required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
ChooseAddressrequest to also request a BTC address for the account of which the NIM address was selected. It does not enforce selecting an account that supports BTC, so thebtcAddressin the result can still beundefined. I have additionally updated theAccountSelectorcomponent in vue-components a bit to display a "BTC" label next to BTC-enabled account labels, if a BTC address is expected in the result.Additionally, I have made all filtering
AccountSelectorprops available as request options, to filter the list of selectable addresses (which makes sense in the CPL case, where contract addresses should not be able to be selected, as they cannot receive NIM).