Add Jpeg2000 to Docker container #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
May 15, 2024
| --dcm2niix \ | ||
| version=v1.0.20220720 \ | ||
| method=source \ | ||
| cmake_opts="-DZLIB_IMPLEMENTATION=Cloudflare -DUSE_JPEGLS=ON -DUSE_OPENJPEG=ON" \ |
There was a problem hiding this comment.
Note: I wonder if we would not get some compatibility issues due to hardware optimized Cloudflare zlib, but I guess we wouldn't know unless we try! ;-)
|
Sorry -- just noted this PR. Thank you for it. Sounds good. Not 100% sure about cloudfare flavor of zlib, but let's try |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :-),
I hope you are doing well. This pull request adds the Jpeg2000 format to the Docker container. I made this change to help a researcher whose MRI dataset could be converted by HeuDiConv otherwise. Please let me know if you need anything else to be added/changed to this pull request.
Kind regards.