Refactor create_seqinfo tiny bit to avoid duplication and add logging; and in tests to reuse list of dicom paths #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file at module level I think it is safer to avoid 3rd party library calls at the module import time since if they are buggy it would be too loud of kaboom. Also it adds CPU time at import time even if not used later on. So replaced with defining a list of all DICOMs and then just using that function directly from filename. This also would run it against more DICOMs as this time we would glob recursively.
…we extracted sequence_name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 82.13% 82.15% +0.02%
==========================================
Files 42 42
Lines 4226 4226
==========================================
+ Hits 3471 3472 +1
+ Misses 755 754 -1 ☔ View full report in Codecov by Sentry. |
bpinsard
requested changes
Sep 24, 2024
Co-authored-by: Basile <basile.pinsard@gmail.com>
bpinsard
approved these changes
Oct 1, 2024
yarikoptic
commented
Oct 1, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to
triggered by desire to avoid "growing" duplication and wanting to avoid call outs to
wrapper_from_fileat the test module import time.