Chore/Enable host-gateway dns on linux docker #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavistan
approved these changes
Jul 3, 2024
|
This is for the people not using Docker Desktop, right? |
|
According to the comments in the issue linked above some docker distributions enable this by default for every container and some don't (don't know about Docker Desktop specifically). It's a documented per-container setting though, and as per the issue above the consensus seems to be to use the host.docker.internal hostname for the host gateway, so that this PR fixes this behavior for for all docker distributions, irrespective of platform and usage of docker Desktop. |
|
great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist