Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 CI broken on v19.x #3221

Closed
targos opened this issue Mar 14, 2023 · 2 comments
Closed

V8 CI broken on v19.x #3221

targos opened this issue Mar 14, 2023 · 2 comments
Labels
ci-public

Comments

@targos
Copy link
Member

targos commented Mar 14, 2023

Example: https://ci.nodejs.org/job/node-test-commit-v8-linux/5221/

09:20:58 export PATH="/usr/bin:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" && \
09:20:58 	/usr/bin/python3.9 deps/v8/tools/run-tests.py --gn --arch=ppc64 --progress=dots --timeout=120 intl \
09:20:58 			mjsunit cctest debugger inspector message preparser \
09:20:58 			--json-test-results /home/iojs/build/workspace/node-test-commit-v8-linux/v8-tap.json --slow-tests-cutoff 1000000
09:20:58 Traceback (most recent call last):
09:20:58   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/run-tests.py", line 11, in <module>
09:20:58     from testrunner import standard_runner
09:20:58   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/standard_runner.py", line 16, in <module>
09:20:58     from testrunner.testproc.progress import ResultsTracker, ProgressProc
09:20:58   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/progress.py", line 9, in <module>
09:20:58     from testrunner.testproc.resultdb import ResultDBIndicator
09:20:58   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/resultdb.py", line 8, in <module>
09:20:58     import requests
09:20:58 ModuleNotFoundError: No module named 'requests'

Main branch doesn't seem affected (it's on a more recent version of V8): https://ci.nodejs.org/job/node-test-commit-v8-linux/5222/
@richardlau
Copy link
Member 

09:20:58 ModuleNotFoundError: No module named 'requests'

@miladfarca came across this with the upstream V8 work. From nodeshift/v8-build@60937fc it looks like this was introduced in https://crrev.com/c/3905385 but that looks like it was reverted in https://chromium-review.googlesource.com/c/v8/v8/+/3952131 (which is probably why the main branch isn't affected).

@richardlau richardlau mentioned this issue Mar 23, 2023
Closed
@richardlau
Copy link
Member

V8 backport PR: nodejs/node#47239

@richardlau richardlau mentioned this issue Apr 7, 2023
Merged
richardlau added a commit to nodejs/node that referenced this issue Apr 13, 2023
@richardlau
deps: V8: cherry-pick f09dde9fbb54
a978ca6 
Original commit message:

    Revert "[resultdb] Add ResultDB indicator"

    This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.

    Reason for revert: breaks flake bisect:
    https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview

    The change added the implicit requirement to run testing with
    vpython3, which is not given everywhere.

    Original change's description:
    > [resultdb] Add ResultDB indicator
    >
    > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
    >
    > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
    >
    > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
    >
    >
    > V8-Recipe-Flags: resultdb
    > Bug: v8:13316
    > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
    > Commit-Queue: Liviu Rau <liviurau@google.com>
    > Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#83672}

    Bug: v8:13316
    Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#83677}

Refs: v8/v8@f09dde9
PR-URL: #47239
Fixes: nodejs/build#3221
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-public
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @richardlau