Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False failure in title-format rule #40

Closed
richardlau opened this issue Dec 15, 2018 · 0 comments
Closed

False failure in title-format rule #40

richardlau opened this issue Dec 15, 2018 · 0 comments
Labels
bug

Comments

@richardlau
Copy link
Member

https://travis-ci.com/nodejs/node/jobs/165397175#L478-L491

*** Commit message for 793eb528fc is:
src: use std::vector for setting up process.execPath

Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

+npx -q core-validate-commit --no-validate-metadata 793eb528fc8a0e5b9e4d63e268080c8e90978a2b
  ✖  793eb528fc8a0e5b9e4d63e268080c8e90978a2b
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      valid subsystems                          subsystem
     ✖  0:13     Add a space after subsystem(s).           title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
@richardlau richardlau mentioned this issue Dec 15, 2018
Closed
2 tasks
addaleax added a commit to addaleax/core-validate-commit that referenced this issue Dec 15, 2018
@addaleax
Allow colons in commit message title
6da53fd 
The title-format rule was previously too eager and disallowed
all usage of colons followed by non-spaces, rather than just
for the subsystem. Fix that by only checking for a space after
the *first* colon.

Fixes: nodejs#40
@addaleax addaleax mentioned this issue Dec 15, 2018
Merged
@richardlau richardlau added the bug label Dec 16, 2018
joyeecheung pushed a commit that referenced this issue Dec 16, 2018
@addaleax @joyeecheung
Allow colons in commit message title (#41)
a3e9d95 
The title-format rule was previously too eager and disallowed
all usage of colons followed by non-spaces, rather than just
for the subsystem. Fix that by only checking for a space after
the *first* colon.

Fixes: #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richardlau