Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-node: simplify PR wait time to 48 hours #288

Merged
merged 1 commit into from
Oct 7, 2018
Merged

git-node: simplify PR wait time to 48 hours #288

merged 1 commit into from
Oct 7, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 7, 2018

@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #288 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #288      +/-   ##
=========================================
- Coverage   74.03%   73.9%   -0.13%     
=========================================
  Files          22      22              
  Lines        1406    1399       -7     
=========================================
- Hits         1041    1034       -7     
  Misses        365     365
Impacted Files Coverage Δ
lib/pr_checker.js 98.33% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11cdc8...eaf4c8a. Read the comment docs.

@priyank-p priyank-p merged commit 57c7f04 into nodejs:master Oct 7, 2018
@trivikr trivikr deleted the wait-time branch October 7, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@priyank-p priyank-p priyank-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @joyeecheung @priyank-p