Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Update http.markdown #6670

Closed
wants to merge 1 commit into from
Closed

Update http.markdown #6670

wants to merge 1 commit into from

Conversation

liveinjs
Copy link

response.finished

response.finished
@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit liveinjs/node@fb94876 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

The following commiters were not found in the CLA:

  • hackerjs

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@jasnell
Copy link
Member

jasnell commented Aug 13, 2015

Hmm... unfortunately it doesn't look like this one was ever reviewed. @liveinjs , thank you for submitting this, sorry it's taken so long for someone to look at it. There are a couple of grammatical issues that should be addressed before it's landed tho; and we should verify that the finished property is meant to be part of the API. @cjihrig @trevnorris ... does this look fine to you?

@jasnell jasnell self-assigned this Aug 13, 2015
@jasnell jasnell added the doc label Aug 14, 2015
@cjihrig
Copy link

cjihrig commented Aug 15, 2015

I'm not 100% sure. Given that it's not underscored, it seems like it should be documented. If we want to document it, this needs a bit of cleanup.

@trevnorris
Copy link

Agree w/ @cjihrig

@jasnell
Copy link
Member

jasnell commented Aug 18, 2015

New cleaned up PR opened. Closing this here.

@jasnell jasnell closed this Aug 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants