fixup: TODO

nodejs · Jan 4, 2020 · 9750a0b · 9750a0b
1 parent 4c7193e
commit 9750a0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -7,6 +7,8 @@ function destroy(err, cb) {
   const r = this._readableState;
   const w = this._writableState;
 
+  // TODO(ronag): readable & writable = false?
+
   if (err) {
     if (w) {
       w.errored = true;
@@ -16,8 +18,6 @@ function destroy(err, cb) {
     }
   }
 
-  // TODO(ronag): readable & writable = false?
-
   if ((w && w.destroyed) || (r && r.destroyed)) {
     if (cb) {
       cb(err);
@@ -131,6 +131,8 @@ function errorOrDestroy(stream, err) {
   const r = stream._readableState;
   const w = stream._writableState;
 
+  // TODO(ronag): readable & writable = false?
+
   if ((r && r.autoDestroy) || (w && w.autoDestroy))
     stream.destroy(err);
   else if (err) {

diff --git a/test/parallel/test-stream-readable-error-end.js b/test/parallel/test-stream-readable-error-end.js
@@ -2,13 +2,12 @@
 
 const common = require('../common');
 const { Readable } = require('stream');
-const assert = require('assert');
 
 {
   const r = new Readable({ read() {} });
 
-  r.on('data', common.mustCall());
   r.on('end', common.mustNotCall());
+  r.on('data', common.mustCall());
   r.on('error', common.mustCall());
   r.push('asd');
   r.push(null);