Skip to content

Commit

Permalink
[squash] UNREACHABLE(); all the things
Browse files Browse the repository at this point in the history
  • Loading branch information
addaleax committed Nov 21, 2017
1 parent 2cd135b commit 9bd517e
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/node_platform.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ void BackgroundTaskRunner::PostTask(std::unique_ptr<Task> task) {
}

void BackgroundTaskRunner::PostIdleTask(std::unique_ptr<v8::IdleTask> task) {
CHECK(false && "idle tasks not enabled");
UNREACHABLE();
}

void BackgroundTaskRunner::PostDelayedTask(std::unique_ptr<v8::Task> task,
double delay_in_seconds) {
// It's unclear whether this is required at all for background tasks.
PostTask(std::move(task));
UNREACHABLE();
}

void BackgroundTaskRunner::BlockingDrain() {
Expand Down Expand Up @@ -77,7 +76,7 @@ void PerIsolatePlatformData::FlushTasks(uv_async_t* handle) {
}

void PerIsolatePlatformData::PostIdleTask(std::unique_ptr<v8::IdleTask> task) {
CHECK(false && "idle tasks not enabled");
UNREACHABLE();
}

void PerIsolatePlatformData::PostTask(std::unique_ptr<Task> task) {
Expand Down

1 comment on commit 9bd517e

@gahaas
Copy link
Contributor

@gahaas gahaas commented on 9bd517e Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please sign in to comment.