Skip to content

Commit

Permalink
build: add --v8-disable-object-print flag
Browse files Browse the repository at this point in the history
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag. remove --v8-enable-object-print flag.
add a --v8-disable-object-print flag instead that defaults to false.

Fixes: #45433
  • Loading branch information
fossamagna committed Nov 14, 2022
1 parent 3770d3a commit c041989
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -772,11 +772,11 @@
'memory footprint, but also implies no just-in-time compilation ' +
'support, thus much slower execution)')

parser.add_argument('--v8-enable-object-print',
parser.add_argument('--v8-disable-object-print',
action='store_true',
dest='v8_enable_object_print',
default=True,
help='compile V8 with auxiliar functions for native debuggers')
dest='v8_disable_object_print',
default=False,
help='disable the V8 auxiliar functions for native debuggers')

parser.add_argument('--v8-enable-hugepage',
action='store_true',
Expand Down Expand Up @@ -1436,7 +1436,7 @@ def configure_v8(o):
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
Expand Down

0 comments on commit c041989

Please sign in to comment.