Skip to content

Commit

Permalink
test: fix ordering of assertion values
Browse files Browse the repository at this point in the history
  • Loading branch information
maccuaa authored and BridgeAR committed Oct 15, 2018
1 parent 98f170f commit ecd9bc0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/addons-napi/test_general/testInstanceOf.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ const v8TestsDirExists = fs.existsSync(v8TestsDir);
// See for instance deps/v8/test/mjsunit/instanceof.js
// eslint-disable-next-line no-unused-vars
function assertTrue(assertion) {
return assert.strictEqual(true, assertion);
return assert.strictEqual(assertion, true);
}

// eslint-disable-next-line no-unused-vars
function assertFalse(assertion) {
assert.strictEqual(false, assertion);
assert.strictEqual(assertion, false);
}

// eslint-disable-next-line no-unused-vars
Expand Down

1 comment on commit ecd9bc0

@BridgeAR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to resolving the conflicts with the merge commit I missed adding the meta data here :-(

This is the missing data:

PR-URL: #23487
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

Please sign in to comment.