Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io.js-v2.0.0 fails with libressl #1622

Closed
Gottox opened this issue May 5, 2015 · 9 comments
Closed

io.js-v2.0.0 fails with libressl #1622

Gottox opened this issue May 5, 2015 · 9 comments

Comments

@Gottox
Copy link

Gottox commented May 5, 2015

It seems, that libressl removed a few functions used in iojs-v2.0.0. Version 1.6.2 works fine. I haven't test other versions.

See this output for more info:

https://gist.github.com/4199d35343200e58a5d7

System: VoidLinux
Linux: 4.0.1
LibreSSL: 2.1.6_3
io.js: 2.0.0
@bnoordhuis
Copy link
Member

I'm going to close this because we don't pretend to support libressl, or anything besides the bundled openssl. Thanks for filing a bug report though.

@Fishrock123
Copy link
Contributor

@Gottox that being said, the reason is probably because we switched to openssl 1.0.2a. If libressl has a compatible version for that, it may work. No guarantees.

@Gottox
Copy link
Author

Gottox commented May 5, 2015

Thanks for this clarification!

@Fishrock123 Fishrock123 mentioned this issue May 13, 2015
Closed
@lucy lucy mentioned this issue May 13, 2015
Closed
@hasufell
Copy link

or anything besides the bundled openssl.

Bundling security relevant libraries is inherently insecure and usually causes distro developers to diverge from upstream by unbundling them.
Figuring out the vulnerabilities of 300 local copies of e.g. zlib is simply impossible system-wide. It also means that updates to the bundles libraries are a lot slower, because they are tied to your releases. As such, there is nothing that can make the user force to update to a non-vulnerable openssl version if he's running iojs vanilla outside of the packagemanager.

@jbergstroem
Copy link
Member

@hasufell That's one of the reasons iojs allows packagers/users to distribute their own openssl by passing --shared-openssl.

@hasufell
Copy link

That's one of the reasons iojs allows packagers/users to distribute their own openssl by passing --shared-openssl.

Then I cannot understand why you say "we don't support it". It's important to support it.

@bnoordhuis
Copy link
Member

The burden of support falls on the packagers, them being the only ones linking to shared libraries. The shared library support was originally contributed by packagers.

@rvagg
Copy link
Member

rvagg commented May 14, 2015

it is something we've discussed testing in our CI cluster, but until that happens we can't claim to support it officially because we simply don't know from release-to-release if it still works

@pSub pSub mentioned this issue May 20, 2015
Closed
@envygeeks
Copy link

Well I hope you never plan to get packaged by Debian since your software is broken there too.

@spacekitteh spacekitteh mentioned this issue Nov 17, 2016
Closed
@misterdjules misterdjules mentioned this issue Oct 4, 2018
Closed
2 tasks
misterdjules pushed a commit that referenced this issue Oct 5, 2018
test: remove obsolete domain test
a8526cb 
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.

This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.

This is no longer the case, and as such that test is no longer needed.

R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Oct 6, 2018
@targos
test: remove obsolete domain test
9c84a64 
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.

This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.

This is no longer the case, and as such that test is no longer needed.

R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Oct 7, 2018
@targos
test: remove obsolete domain test
a070842 
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.

This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.

This is no longer the case, and as such that test is no longer needed.

R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this issue Oct 17, 2018
@jasnell
test: remove obsolete domain test
2270ae2 
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.

This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.

This is no longer the case, and as such that test is no longer needed.

R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-bot snyk-bot mentioned this issue May 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 21, 2022
Open
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this issue May 5, 2024
test: remove obsolete domain test
b5e2e0c 
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.

This was needed because before the changes in
nodejs/node#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.

This is no longer the case, and as such that test is no longer needed.

Refs: nodejs/node#16222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@envygeeks @jbergstroem @bnoordhuis @rvagg @Gottox @Fishrock123 @hasufell