parallel/test-http-pipeline-flood being flaky

[gibfahn]

• Version: 6.11.4.0
• Platform: Windows server 2012 and 2016
• Subsystem: test

Haven't seen this in CI, but I see it on our Windows boxes all the time.

not ok 550 parallel/test-http-pipeline-flood
  ---
  duration_ms: 0.718
  severity: fail
  stack: |-
    
    assert.js:80
      throw new assert.AssertionError({
      ^
    AssertionError: Unexpected data received
        at fail (c:\build\jenkins-new\v6tstwin\x64node\node\test\common\index.js:477:10)
        at Socket.mustNotCall (c:\build\jenkins-new\v6tstwin\x64node\node\test\common\index.js:483:5)
        at emitOne (events.js:101:20)
        at Socket.emit (events.js:188:7)
        at readableAddChunk (_stream_readable.js:176:18)
        at Socket.Readable.push (_stream_readable.js:134:10)
        at TCP.onread (net.js:547:20)
  ...

Example log from when it fails:

backloggedReqs: 1238
res: ServerResponse {
  domain: null,
  _events: { finish: [Function: resOnFinish] },
  _eventsCount: 1,
  _maxListeners: undefined,
  output: [],
  outputEncodings: [],
  outputCallbacks: [],
  outputSize: 0,
  writable: true,
  _last: false,
  upgrading: false,
  chunkedEncoding: false,
  shouldKeepAlive: true,
  useChunkedEncodingByDefault: true,
  sendDate: true,
  _removedHeader: { ‘content-length’: false },
  _contentLength: null,
  _hasBody: true,
  _trailer: ‘’,
  finished: true,
  _headerSent: true,
  socket: null,
  connection: null,
  _header: ‘HTTP/1.1 200 OK\r\ncontent-length: 10240\r\nDate: Wed, 18 Oct 2017 16:03:38 GMT\r\nConnection: keep-alive\r\n\r\n’,
  _headers: { ‘content-length’: 10240 },
  _headerNames: { ‘content-length’: ‘content-length’ },
  _onPendingData: [Function: updateOutgoingData],
  statusMessage: ‘OK’,
  statusCode: 200 }

[gibfahn]

Previously #6450, but that was in theory fixed.

[BridgeAR]

I saw something similar on the CI. It was a different error but the test itself seems flaky, so I decided to just add it to this issue.

https://ci.nodejs.org/job/node-test-pull-request/12065/

not ok 795 parallel/test-http-pipeline-flood
  ---
  duration_ms: 2.673
  severity: fail
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
        at Object.exports.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:497:10)
        at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-http-pipeline-flood.js:59:35)
        at Object.onceWrapper (events.js:218:13)
        at Server.emit (events.js:126:13)
        at emitListeningNT (net.js:1397:10)
        at process._tickCallback (internal/process/next_tick.js:152:19)
        at Function.Module.runMain (module.js:703:11)
        at startup (bootstrap_node.js:195:16)
        at bootstrap_node.js:646:3
  ...

[BridgeAR]

Fixed by #17955

[BethGriggs]

I can still reproduce the first error 'Unexpected data received' with the test changes from #17955. I have seen this failure on Win 7 in addition to Win 2012 and Win2016.

[BridgeAR]

@BethGriggs thanks! Seems like I missed that the test had two issues and that the PR only fixed one.

[apapirovski]

We have not seen this fail on our infra and we can't get it to fail for anyone that runs Windows. IMO this can be closed unless someone who can reproduce is willing to fix it...