Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm #2979

SergeKornilov · 2015-09-21T10:09:52Z

I get the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" trying to install any module by npm via proxy, for example, request or cheerio:

npm config set proxy http://username:password@proxy.company.com:8080
npm config set https-proxy https://username:password@proxy.company.com:8080

npm install cheerio

//

Thus, request module is not installed at all, and cheerio module is installed without dependencies.

//

npm --version
2.14.3

node --version
v4.1.0

OS: windows xp sp3

ChALkeR · 2015-09-21T10:41:45Z

cc @indutny

rvagg · 2015-09-21T12:04:14Z

/cc @nodejs/crypto, @nodejs/platform-windows (windows xp sp3 sets off red flags for me)

thefourtheye · 2015-09-21T12:08:25Z

Npm folks might also be interested. cc @othiym23 @zkat @iarna

indutny · 2015-09-21T17:46:31Z

Will look at it today...

indutny · 2015-09-21T18:36:55Z

I think it may be related to the Windows XP indeed. Checking the libuv code with this regards.

indutny · 2015-09-21T18:45:02Z

Hm... looks like I was wrong about it, the order of callbacks should be correct even on XP. Continuing the search.

indutny · 2015-09-21T23:05:42Z

I think it may be a windows-specific thing. May I ask you to give a try to the following patch:

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index 1bff757..fc9696f 100644
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -296,7 +296,11 @@ proxiedMethods.forEach(function(name) {

 tls_wrap.TLSWrap.prototype.close = function closeProxy(cb) {
   if (this._parentWrap && this._parentWrap._handle === this._parent) {
-    setImmediate(cb);
+    if (this._parentWrap._handle)
+      this._parentWrap.once('close', cb);
+    else
+      setImmediate(cb);
+
     return this._parentWrap.destroy();
   }
   return this._parent.close(cb);

Hopefully, it will fix the problem

@saghul a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

When closing the child TLSWrap handle - wait for the proper parent's handle close callback invocation. `uv_close_cb` may be invoked much later than the next libuv tick, depending on the platform. Fix: nodejs#2979

indutny · 2015-09-21T23:24:24Z

Relevant PR: #2991

saghul · 2015-09-22T07:10:29Z

a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

Yes, AFAIK cancellation could take a bit, so the uv_close callback is not guaranteed to run exactly on the next tick.

indutny · 2015-09-24T19:12:17Z

@SergeKornilov may I ask you to test this patch? I have really good expectations from it. Let me know if you need some help with building this thing.

SergeKornilov · 2015-09-25T06:19:19Z

@indutny It something goes wrong when I try to build node.js. I follow installation guide:

Start "Visual Studio Command prompt (2010)"
Execute "set path=c:\python27;c:\python27\lib;%path%"
Execute "python --version" to check and get the result "Python 2.7.10"
Then execute "vcbuild.bat release x86" and get nothing.

What's wrong here? obsolet version of VS?

indutny · 2015-09-25T06:22:51Z

cc @nodejs/release how do we do builds for Windows?

Fishrock123 · 2015-09-25T06:45:09Z

@nodejs/build ^^

saghul · 2015-09-25T07:40:20Z

I always do it from cmd.exe, give it a shot.
On Sep 25, 2015 8:20 AM, "SergeKornilov" notifications@github.com wrote:

@indutny https://github.com/indutny It something goes wrong when I try
to build node.js. I follow installation guide:

Start "Visual Studio Command prompt (2010)"

Execute "set path=c:\python27;c:\python27\lib;%path%"

Execute "python --version" to check and get the result "Python
2.7.10"

Then execute "vcbuild.bat release x86" and get nothing.

What's wrong here? obsolet version of VS?

—
Reply to this email directly or view it on GitHub
#2979 (comment).

SergeKornilov · 2015-09-25T07:59:03Z

What can I do to clearify the situation and get more verbous output from vcbuild?

seishun · 2015-09-25T12:25:08Z

VS 2010 support was dropped a long time ago. You need at least VS 2013.

SergeKornilov · 2015-09-25T12:34:16Z

What is about Windows SDK 7.1?

seishun · 2015-09-25T12:37:27Z

Unless Windows SDK includes a compiler, its version is not relevant.

saghul · 2015-09-25T12:56:34Z

VS 2010 support was dropped a long time ago. You need at least VS 2013.

In Node? When?

Unless Windows SDK includes a compiler, its version is not relevant.

Windows SDk 7 and 7.1 do include a compiler.

seishun · 2015-09-25T13:02:42Z

In Node? When?

In 370e821.

Windows SDk 7 and 7.1 do include a compiler.

That's interesting. Is it an alternative to VS then? Anyway, I'm not sure how or if node would work with it, as vcbuild.bat looks for environment variables set by VS.

saghul · 2015-09-25T13:07:24Z

Thanks, I didn't know that! In libuv we support VS >= 2008 :-)

That's interesting. Is it an alternative to VS then? Anyway, I'm not sure how or if node would work with it, as vcbuild.bat looks for environment variables set by VS.

Not really. AFAIK Windows SDK >= 8 no longer includes any compiler.

IIRC you could compile stuff for x64 with VS 2012 express + the SDK.

SergeKornilov · 2015-09-25T13:36:41Z

Here, on an another computer with Windows SDK 7.1 and Python 2.7 only:

So, I guess the following (from Installation)

You need to have Microsoft Visual Studio 2012/2010 (Express edition is fine) as well as Python 2.6/2.7.

is not actual now at least for 4.x version.

orangemocha · 2015-09-25T13:47:18Z

What can I do to clearify the situation and get more verbous output from vcbuild?

@SergeKornilov : edit vcbuild.bat and remove (or comment with REM) the first line. Eg:

REM @echo off

SergeKornilov · 2015-09-25T13:54:43Z

Well, here it is (last lines of the output):

C:\nodejsbuild\node-master>set NODE_VERSION=
C:\nodejsbuild\node-master>set TAG=
C:\nodejsbuild\node-master>set FULLVERSION=
C:\nodejsbuild\node-master>for /F "usebackq tokens=*" %i in (`python "C:\nodejsbuild\node-master\tools\getnodeversion.py"`) do s
et NODE_VERSION=%i
C:\nodejsbuild\node-master>set NODE_VERSION=5.0.0
C:\nodejsbuild\node-master>rem echo 5.0.0
C:\nodejsbuild\node-master>if not defined NODE_VERSION (
echo Cannot determine current version of Node.js
 exit /b 1
)
C:\nodejsbuild\node-master>if not defined DISTTYPE set DISTTYPE=release
C:\nodejsbuild\node-master>if "release" == "release" (
set FULLVERSION=5.0.0
 goto exit
)
C:\nodejsbuild\node-master>if not defined DISTTYPEDIR set DISTTYPEDIR=release
C:\nodejsbuild\node-master>goto :EOF
C:\nodejsbuild\node-master>

orangemocha · 2015-09-25T13:57:12Z

I haven't tried this myself, but as far as I know VS2013 can only be installed on Windows 7 or later (or the corresponding server editions, Windows Server 2008 R2 or later). And since building Node requires VS2013 or VS2015, that disqualifies XP as a build machine.

SergeKornilov · 2015-09-25T14:04:41Z

As far as I can see I need Windows 7 with VS2013, only then I can build node targeted it for XP, right?

orangemocha · 2015-09-25T14:11:04Z

Correct. You might as well go to the latest and greatest and use VS2015. You'll need Windows 7 SP1 minimum.

Looking at your output above, there also seems to be a bug in vcbuild.bat. For one thing, I can see that it contains two labels named the same (:exit). Hopefully this only causes problems on XP. Please let us know if you still have problems on later OS versions.

orangemocha · 2015-09-25T14:19:07Z

As a side thought, I wonder if the VS 2013 minimum requirement also applies to compiling native modules. If that is the case, it would mean that Node on XP is seriously limited.

SergeKornilov · 2015-09-25T14:27:12Z

Ok. I'll try to build node on Win7 a bit later... I have only to install VS 2013. Merlin's beard! I just wanted to install cheerio module via npm 😃.

janaka1379 · 2015-09-29T06:22:57Z

I am using windows 10. I also having that issue.
"Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320"
Any one have solutions?

indutny · 2015-09-29T06:34:29Z

@janaka1379 we probably have one! May I ask you to give a try to that patch?

Fishrock123 · 2015-10-06T02:52:06Z

Any update? @janaka1379 did you try using the patch? (#2991)

Edited: I think fedor meant this patch

nullivex · 2015-10-07T06:01:36Z

I am seeing this issue too when testing my platform that worked on previous node versions.

I will attempt to build with this patch and let you know.

SergeKornilov · 2015-10-07T09:43:21Z

The latest version of node.js (4.1.2) has the same problem.

indutny · 2015-10-07T16:03:39Z

@SergeKornilov of course it does, I haven't landed the patch yet.

ChALkeR · 2015-10-07T18:58:35Z

@indutny Am I correct that the problem could be observed only on windows platform?

indutny · 2015-10-07T19:03:23Z

@ChALkeR so far it looks like this

veneMarcos · 2015-10-07T20:07:32Z

I have the same problem in Win XP.
I try install a express with command line npm install express -g and I get the msg ""Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320"

veneMarcos · 2015-10-08T13:14:33Z

Where do I put this code?

I do not find the file tls_wrap.cc.

ChALkeR · 2015-10-08T13:39:22Z

@veneMarcos tls_wrap.cc is here: https://github.com/nodejs/node/blob/master/src/tls_wrap.cc , but I'm not exactly sure why are you trying to find it. The patch is against _tls_wrap.js, which could be found here: https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js .

wwwork · 2015-10-12T13:21:49Z

I get the same error on win xp, when I've run npm install

npm --proxy http://191.168.1.1:3128 --without-ssl --insecure install string.
I think it because I using proxy in my local arean network.

node --version
v4.1.2

When closing the child TLSWrap handle - wait for the proper parent's handle close callback invocation. `uv_close_cb` may be invoked much later than the next libuv tick, depending on the platform. The only platform that currently seem to defer `uv_close_cb` is Windows XP. This behavior was not observed on other Windows systems, and is not possible on Unixes. Fix: #2979 PR-URL: #2991 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

indutny · 2015-10-12T19:33:17Z

Please give it a try to node.js 4.2.0 . The problem should be fixed there.

SergeKornilov · 2015-10-13T05:28:26Z

Thank you very much! 4.2.0 really works great!

veneMarcos · 2015-10-13T13:47:14Z

Thank you, this version 4.2.0 works fine.

indutny · 2015-10-13T14:44:34Z

Whoa, looks like it was a good call to include that fix into release. Thank you!

mypuem · 2016-04-11T09:22:18Z

I'm seeing this issue in node 4.4 running on win 7 and ubuntu 14.04.4 LTS. The error is printed when an ssl socket is closed. I'm only using the built in modules http, https, crypto. My code runs fine without the https module. Sorry if I've posted in the wrong place but this is the only reference I can find to this error. The error message is "Assertion failed: (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 319".

bnoordhuis · 2016-04-11T19:06:41Z

@mypuem If you still get that with the latest v4.x release (v4.4.2 at the time of writing), can you file a new issue and include steps to reproduce? The test case should preferably not depend on any third-party modules.

ChALkeR added the tls Issues and PRs related to the tls subsystem. label Sep 21, 2015

mscdex changed the title ~~Getting the error "Assertion failed (wrap->ssl_) != (nullprt), file src\tls_wrap.cc, line 320" while module installation by npm~~ Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm Sep 21, 2015

indutny mentioned this issue Sep 21, 2015

tls: use parent handle's close callback #2991

Closed

ChALkeR added the windows Issues and PRs related to the Windows platform. label Oct 7, 2015

indutny closed this as completed in 51325c0 Oct 12, 2015

ChALkeR mentioned this issue Nov 12, 2015

Drop Windows XP (and Vista) support in 6.0 #3804

Closed

askmike mentioned this issue Aug 22, 2017

installation problems. askmike/gekko#1019

Closed

Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm #2979

Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm #2979

Comments

SergeKornilov commented Sep 21, 2015

ChALkeR commented Sep 21, 2015

rvagg commented Sep 21, 2015

thefourtheye commented Sep 21, 2015

indutny commented Sep 21, 2015

indutny commented Sep 21, 2015

indutny commented Sep 21, 2015

indutny commented Sep 21, 2015

indutny commented Sep 21, 2015

saghul commented Sep 22, 2015

indutny commented Sep 24, 2015

SergeKornilov commented Sep 25, 2015

indutny commented Sep 25, 2015

Fishrock123 commented Sep 25, 2015

saghul commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

seishun commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

seishun commented Sep 25, 2015

saghul commented Sep 25, 2015

seishun commented Sep 25, 2015

saghul commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

orangemocha commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

orangemocha commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

orangemocha commented Sep 25, 2015

orangemocha commented Sep 25, 2015

SergeKornilov commented Sep 25, 2015

janaka1379 commented Sep 29, 2015

indutny commented Sep 29, 2015

Fishrock123 commented Oct 6, 2015

nullivex commented Oct 7, 2015

SergeKornilov commented Oct 7, 2015

indutny commented Oct 7, 2015

ChALkeR commented Oct 7, 2015

indutny commented Oct 7, 2015

veneMarcos commented Oct 7, 2015

veneMarcos commented Oct 8, 2015

ChALkeR commented Oct 8, 2015

wwwork commented Oct 12, 2015

indutny commented Oct 12, 2015

SergeKornilov commented Oct 13, 2015

veneMarcos commented Oct 13, 2015

indutny commented Oct 13, 2015

mypuem commented Apr 11, 2016

bnoordhuis commented Apr 11, 2016