Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky test-child-process-fork-exec-path in CI #30620

Closed
gireeshpunathil opened this issue Nov 24, 2019 · 2 comments
Closed

investigate flaky test-child-process-fork-exec-path in CI #30620

gireeshpunathil opened this issue Nov 24, 2019 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@gireeshpunathil
Copy link
Member

  • Version: master
  • Platform: windows
  • Subsystem: child_process
11:54:22 not ok 126 parallel/test-child-process-fork-exec-path
11:54:22   ---
11:54:22   duration_ms: 0.494
11:54:22   severity: fail
11:54:22   exitcode: 1
11:54:22   stack: |-
11:54:22     Can't clean tmpdir: c:\workspace\node-test-binary-windows-2\test\.tmp.126
11:54:22     Files blocking: [ 'node-copy.exe' ]
11:54:22     
11:54:22     c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:136
11:54:22         throw e;
11:54:22         ^
11:54:22     
11:54:22     Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows-2\test\.tmp.126'
11:54:22         at Object.rmdirSync (fs.js:768:3)
11:54:22         at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:86:10)
11:54:22         at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:41:7)
11:54:22         at process.onexit (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:121:5)
11:54:22         at process.emit (events.js:215:7) {
11:54:22       errno: -4051,
11:54:22       syscall: 'rmdir',
11:54:22       code: 'ENOTEMPTY',
11:54:22       path: 'c:\\workspace\\node-test-binary-windows-2\\test\\.tmp.126'
11:54:22     }
11:54:22   ...

ref: https://ci.nodejs.org/job/node-test-binary-windows-2/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/4420/console

@richardlau richardlau added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Dec 8, 2019
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 12, 2019
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: nodejs#30620
Fixes: nodejs#30844
@Trott Trott closed this as completed in edf654d Dec 12, 2019
MylesBorins pushed a commit that referenced this issue Dec 13, 2019
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jan 14, 2020
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
Replace the homegrown rimrafsync implementation in test/common with
a call to `fs.rmdirSync(path, { recursive: true })`.

Fixes: #30620
Fixes: #30844

PR-URL: #30849
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants