Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test-esm-loader-http-imports #47836

Open
tniessen opened this issue May 3, 2023 · 3 comments
Open

Flaky test-esm-loader-http-imports #47836

tniessen opened this issue May 3, 2023 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. linux Issues and PRs related to the Linux platform. loaders Issues and PRs related to ES module loaders

Comments

@tniessen
Copy link
Member

tniessen commented May 3, 2023

Test

test-esm-loader-http-imports

Platform

FreeBSD, Ubuntu

Console output

not ok 3516 es-module/test-esm-loader-http-imports
  ---
  duration_ms: 35369.84900
  severity: fail
  exitcode: 1
  stack: |-
    TAP version 13
    # Subtest: ESM: http import via loader
        # Subtest: should load using --import flag
        ok 1 - should load using --import flag
          ---
          duration_ms: 27722.691074
          ...
        # Subtest: should load using import inside --eval code
        not ok 2 - should load using import inside --eval code
          ---
          duration_ms: 32812.699449
          failureType: 'testCodeFailure'
          error: |-
            Expected values to be strictly equal:
            + actual - expected
            
            + '\n' +
            +   'node:internal/process/esm_loader:42\n' +
            +   "      internalBinding('errors').triggerUncaughtException(\n" +
            +   '                                ^\n' +
            +   'Error: read ECONNRESET\n' +
            +   '    at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {\n' +
            +   '  errno: -54,\n' +
            +   "  code: 'ECONNRESET',\n" +
            +   "  syscall: 'read'\n" +
            +   '}\n' +
            +   '\n' +
            +   'Node.js v21.0.0-pre\n'
            - ''
          code: 'ERR_ASSERTION'
          name: 'AssertionError'
          expected: ''
          actual: |-
            
            node:internal/process/esm_loader:42
                  internalBinding('errors').triggerUncaughtException(
                                            ^
            Error: read ECONNRESET
                at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
              errno: -54,
              code: 'ECONNRESET',
              syscall: 'read'
            }
            
            Node.js v21.0.0-pre
            
          operator: 'strictEqual'
          stack: |-
            TestContext.<anonymous> (file:///usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/es-module/test-esm-loader-http-imports.mjs:82:12)
            async Test.run (node:internal/test_runner/test:569:9)
            async Promise.all (index 1)
            async Suite.run (node:internal/test_runner/test:801:7)
            async startSubtest (node:internal/test_runner/harness:203:3)
          ...
        1..2
    not ok 1 - ESM: http import via loader
      ---
      duration_ms: 32832.042997
      type: 'suite'
      failureType: 'subtestsFailed'
      error: '1 subtest failed'
      code: 'ERR_TEST_FAILURE'
      ...
    1..1
    # tests 2
    # suites 1
    # pass 1
    # fail 1
    # cancelled 0
    # skipped 0
    # todo 0
    # duration_ms 32844.969687
  ...

Build links

Additional information

cc @nodejs/loaders

@tniessen tniessen added flaky-test Issues and PRs related to the tests with unstable failures on the CI. loaders Issues and PRs related to ES module loaders labels May 3, 2023
@github-actions github-actions bot added the freebsd Issues and PRs related to the FreeBSD platform. label May 3, 2023
@MrJithil
Copy link
Member

MrJithil commented May 8, 2023

Seems this issue could be closed. @tniessen

@tniessen
Copy link
Member Author

tniessen commented May 8, 2023

@MrJithil Why? Did a fix land?

@tniessen tniessen added the linux Issues and PRs related to the Linux platform. label May 13, 2023
tniessen added a commit to tniessen/node that referenced this issue May 13, 2023
This test has been failing occasionally for weeks.

Refs: nodejs#47836
Refs: nodejs/reliability#564
nodejs-github-bot pushed a commit that referenced this issue May 15, 2023
This test has been failing occasionally for weeks.

Refs: #47836
Refs: nodejs/reliability#564
PR-URL: #47987
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue May 15, 2023
This test has been failing occasionally for weeks.

Refs: #47836
Refs: nodejs/reliability#564
PR-URL: #47987
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
This test has been failing occasionally for weeks.

Refs: #47836
Refs: nodejs/reliability#564
PR-URL: #47987
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this issue Jul 6, 2023
This test has been failing occasionally for weeks.

Refs: nodejs#47836
Refs: nodejs/reliability#564
PR-URL: nodejs#47987
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RedYetiDev
Copy link
Member

I'm not sure about FreeBSD, but I can't reproduce on x64 Linux:

$ tools/test.py --repeat 999 test/es-module/test-esm-loader-http-imports.mjs 
[00:42|% 100|+ 999|-   0]: Done                                

All tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. linux Issues and PRs related to the Linux platform. loaders Issues and PRs related to ES module loaders
Projects
None yet
Development

No branches or pull requests

3 participants