Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation jump-to-header is buggy #53584

Closed
nicholaswmin opened this issue Jun 25, 2024 · 7 comments
Closed

Documentation jump-to-header is buggy #53584

nicholaswmin opened this issue Jun 25, 2024 · 7 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@nicholaswmin
Copy link

nicholaswmin commented Jun 25, 2024

Version

Chrome 125

Platform

Mac OS Sonoma

Subsystem

No response

What steps will reproduce the bug?

Visiting this: https://nodejs.org/api/test.html#running-tests-from-the-command-line

Screenshot 2024-06-25 at 3 28 39 PM

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

It jumps to the correct header

What do you see instead?

It jumps to the wrong header

Additional information

No response

@RedYetiDev
Copy link
Member

Duplicate of #39776

@RedYetiDev RedYetiDev marked this as a duplicate of #39776 Jun 25, 2024
@RedYetiDev RedYetiDev closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
@RedYetiDev RedYetiDev added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jun 25, 2024
@nicholaswmin
Copy link
Author

nicholaswmin commented Jun 28, 2024

Right - so the docs are broken for the past 3 years and the solution is to wait for a response from the Chromium team?

Want me to submit a PR?

@RedYetiDev
Copy link
Member

RedYetiDev commented Jun 28, 2024

If you’ve found a patch, feel free to suggest one :-)

@valadaptive
Copy link

valadaptive commented Jun 29, 2024

As I mentioned in #39776, this is not a Chromium bug, and occurs in Firefox as well. I believe it was not previously showing up in Firefox simply because they had not yet implemented the relevant CSS feature.

It appears to be an effect of #37301. Lazy-loading the content means it is impossible for the browser to tell where to jump to, because it hasn't done the layout.

Optimizing for the case of reading the entire API docs on a single huge page, at the expense of making it frustrating and difficult to navigate the individual documentation sections that show up way more often in web search results, seems like the wrong decision to me.

@nicholaswmin
Copy link
Author

@valadaptive indeed - well the idea I have is just a snipper of JS to scrollTo and offset.

But it's not gonna be accessible without JS. I'm on the fence on whether that's appropriate; @RedYetiDev

@RedYetiDev
Copy link
Member

AFAIK the project doesn't have plans to use JS in the documentation.

But, the project is working on a redesign, which should patch this issue in the process. I wouldn't look to much into this issue, as when the redesign is done it'll (hopefully) be fixed.

@nicholaswmin
Copy link
Author

nicholaswmin commented Jun 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

3 participants