Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.10.0 proposal #10974

Merged
merged 169 commits into from
Feb 22, 2017
Merged

v6.10.0 proposal #10974

merged 169 commits into from
Feb 22, 2017

Conversation

MylesBorins
Copy link
Contributor

2017-02-21, Version 6.10.0 'Boron' (LTS), @MylesBorins

Notable Changes

Coming Soon

Commits

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v6.x labels Jan 24, 2017
@MylesBorins MylesBorins changed the title V6.10.0 proposal v6.10.0 proposal Jan 24, 2017
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jan 24, 2017 •
edited
Loading

ci: https://ci.nodejs.org/job/node-test-pull-request/6022/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/540/
rc.1: https://nodejs.org/download/rc/v6.10.0-rc.1

edit:

failures on arm
ci 2: https://ci.nodejs.org/job/node-test-pull-request/6031/
citgm on v6.9.4 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/542/

@mscdex mscdex removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 24, 2017
matthewaveryusa and others added 22 commits January 31, 2017 17:07
@matthewaveryusa @MylesBorins
deps: fix compile bug in v8/lookup.h
fdc373d 
Fixed a small error that manifests when --debug is specified. This
seems to have been introduced during the backport #9422.

Ref: #9422
PR-URL: #10525
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
@targos @MylesBorins
deps: cherry-pick baba152 from V8 upstream
f77fcf8 
Original commit message:

  fix stepping out of across throwing.

  R=jgruber@chromium.org
  BUG=v8:5559

  Review-Url: https://codereview.chromium.org/2445233004
  Cr-Commit-Position: refs/heads/master@{#40549}

PR-URL: #10689
Fixes: #9175
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@indutny @MylesBorins
process: add process.memoryUsage.external
8ea4487 
PR-URL: #9587
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@anoff @MylesBorins
doc: update path.format description and examples
639ef41 
* removed pseudo-code
* added info on which properties have priority
* modified examples to show ignored properties

PR-URL: #10046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@kmccmk9 @MylesBorins
test: refactor test-net-keepalive.js
58c5bdc 
- Replace require() vars with const.
- Replace assert.equal() with assert.strictEqual().
- Add common.mustCall() to the setTimeout() callback.

PR-URL: #9995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123 @MylesBorins
doc: add some info on tty#setRawMode()
7815efa 
Partially taken from https://linux.die.net/man/3/cfmakeraw

A very simple test script:

```
if (process.argv[2] === 'raw')
  process.stdin.setRawMode(true)

process.stdin.on('data', (chunk) => {
  console.log(chunk)
  console.log(chunk.toString())
})
```

Refs: #10037
PR-URL: #10147
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott @MylesBorins
test: fix flaky test-net-socket-timeout
a56b22e 
The setTimeout() call is unneeded. If the socket never times out, then
the test will never finish. Because timers can be unreliable on machines
under load, using setTimeout() here effectively creates a race
condition.

PR-URL: #10172
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins
http: remove stale timeout listeners
b5f7471 
In order to prevent a memory leak when using keep alive, ensure that the
timeout listener for the request is removed when the response has ended.

PR-URL: #9440
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joyeecheung @MylesBorins
test: increase test coverage of BufferList
717b4b4 
Add tests for edges cases of BufferList:
- test operations when the length is 0
- test operations when the list only has one element

PR-URL: #10171
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
test: refactor test-http-unix-socket
8e7f150 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@mattcphillips @MylesBorins
test: check for error on invalid signal
56a512f 
Asserts that an error should be thrown when
an invalid signal is passed to process.kill().

PR-URL: #10026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev @MylesBorins
tools: add macosx-firwall script to avoid popups
0162908 
Currently, there are a number of popups that get displayed when running
the tests asking to accept incoming network connections. Rules can be
added manually to the socket firewall on Mac OS X but getting this right
might not be obvious and quite a lot of time can be wasted trying to get
the rules right. This script hopes to simplify things a little so that
it can be re-run when needed.

The script should be runnable from both the projects root directory and
from the tools directory, for example:
$ sudo ./tools/macosx-firewall.sh

Fixes: #8911
PR-URL: #10114
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
doc: add note to parallelize make
5b6317b 
Adds a note to the BUILDING doc to encourage parallelizing make. When I
first built node I didn't know this trick and thought that the build was
just stuck in an infinite loop after waiting for 10 minutes.

Refs: #8286
Refs: #9881

PR-URL: #9961
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@MylesBorins
doc: standardizing on make -j4
718b590 
Standardizes docs to use -j4 instead of -j8 as it appears to be the
most inclusive recommendation based on discussion in
#9961.

PR-URL: #9961
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@targos @MylesBorins
lib,test: use consistent operator linebreak style
5ddd508 
We have a tacit rule that for multiline statements, the operator should
be placed before the linebreak. This commit commit fixes the few
violations of this rule in the code base.
This allows us to enable the corresponding ESLint rule.

PR-URL: #10178
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos @MylesBorins
tools: enforce consistent operator linebreak style
e8effa4 
Adds the `operator-linebreak` rule to our ESLint config.

PR-URL: #10178
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas @MylesBorins
test: stream readableListening internal state
a75883e 
PR-URL: #9864
Refs: #8683
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
test: improving crypto fips
951ddb3 
- using strictEqual instead equal
- cast `response` to Number()

PR-URL: #10002
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@pallxk @MylesBorins
doc: fix typo in code example of 'path' module
9988f02 
PR-URL: #10136
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt @MylesBorins
doc: modernize child_process example code
e53262c 
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.

PR-URL: #10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@edsadr @MylesBorins
test: add ES6 and strictEqual to test-fs-truncate
c65dfa9 
- use const and let for variables
- replace assert.equal with assert.strictEqual

PR-URL: #10167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@Trott @MylesBorins
test: refactor test-handle-wrap-close-abort
b2b2774 
* use common.mustCall() to confirm number of uncaught exceptions
* var -> const
* specify duration of 1ms for setTimeout() and setInterval()

PR-URL: #10188
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
cristiancavalli and others added 2 commits January 31, 2017 17:07
@cristiancavalli @MylesBorins
deps: backport 7c3748a from upstream V8
2a39d1c 
Original commit message:
    load correct stack slot for frame details.

    R=bmeurer@chromium.org
    BUG=v8:5071

    Review URL: https://codereview.chromium.org/2045863002 .

    Cr-Commit-Position: refs/heads/master@{#36769}

PR-URL: #10881
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
doc: fix changelog for v6
15df5c0 
Somehow things got out of sync.

PR-URL: #11090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ghost
Copy link

ghost commented Feb 6, 2017

I've finally installed v6.10.0-rc.1 and conducted a few tests within an environment where a self-signed certificate is used to re-encrypt SSL traffic. Using the certificate extension feature from #9139, setting the NODE_EXTRA_CA_CERTS environment variable, I was able to interact with HTTPS URLs successfully. Thank you all for your efforts to get that feature rolled into an upcoming minor LTS release.

@MylesBorins
Copy link
Contributor Author

@destroyerofbuilds if you boot up v4.8.0-rc.3 you should be able to test it there too!

@ghost ghost mentioned this pull request Feb 6, 2017
Merged
@targos targos mentioned this pull request Feb 7, 2017
Closed
thefourtheye and others added 6 commits February 21, 2017 17:00
@thefourtheye @MylesBorins
doc: replace newlines in deprecation with space
50c2ecd 
As it is, each line in the deprecation heading which are wrapped at 80
characters in the *.md files, are shown in different lines. For example

    > Stability: 0 - Deprecated: Use
    > `Buffer.from(arrayBuffer[, byteOffset [, length]])`
    > instead.

is shown in three different lines. This patch replaces the newlines
with space characters, so that the output will be in single line.

PR-URL: #11074

Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jboarman @MylesBorins
doc: correct vcbuild options for windows testing
76e6e7e 
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: #10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@MylesBorins
test: add --abort-on-timeout option to test.py
fce1d10 
Currently, when a process times out, it is terminated by sending it the
SIGTERM signal. Sending SIGBART instead allows the operating system to
generate a core file that can be investigated later using post-mortem
debuggers such as llnode or mdb_v8.

This can be very useful when investigating flaky tests that time out,
since in that case the failure is difficult to reproduce, and being able
to look at a core file makes a big difference.

With these changes, passing the --abort-on-timeout command line option
to tools/test.py now sends SIGABRT to processes timing out on all
platforms but Windows.

PR-URL: #11086
Ref: #11026
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
test: fix test.py command line options processing
8f00f70 
#11086 had introduced a regression
that broke command line options processing for tools/test.py.

Basically, it made tools/test.py discard the command line argument that
would be passed after `--abort-on-timeout`. For instance, when running:

```
$ python tools/test.py --abort-on-timeout path/to/some-test
```

all tests would be run because the last command line argument
(`/path/to/some-test`) would be discarded.

This change fixes this regression.

Refs: #11086
PR-URL: #11153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@thefourtheye @MylesBorins
doc: killSignal option accepts integer values
78b83e7 
`killSignal` option accepts the signal name or signal number as well.

PR-URL: #10424
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@thefourtheye @MylesBorins
doc: change logical to bitwise OR in dns lookup
055f666 
The `hints` value will be a number. To specify more than one hints,
their corresponding bits have to be set. So bitwise OR should be used
instead of logical OR.

PR-URL: #11037

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins force-pushed the v6.10.0-proposal branch 2 times, most recently from a4ed9dd to d0b61c7 Compare February 21, 2017 22:07
@MylesBorins
Copy link
Contributor Author

One more CI + citgm

https://ci.nodejs.org/job/node-test-commit/8057/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/589/

@TimothyGu
Copy link
Member

I wouldn't be devastated if there wasn't enough time left for this release, but can someone take a look at #11387?

@MylesBorins
Copy link
Contributor Author

@TimothyGu #11387 will have to go out in a v7.x release and have at least two weeks without any bugs before we can backport

@MylesBorins
2017-02-21, Version 6.10.0 'Boron' (LTS)
1b6fd44 
Notable Changes:

The SEMVER-MINOR changes include:

*  crypto: allow adding extra certs to well-known CAs (Sam Roberts)
   #9139
*  deps: Upgrade INTL ICU to version 58 (Steven R. Loomis)
   #9234
*  process: add `process.memoryUsage.external` (Fedor Indutny)
   #9587
*  src: add wrapper for process.emitWarning() (Sam Roberts)
   #9139

Notable SEMVER-PATCH changes include:

*  fs: cache non-symlinks in realpathSync. (Jeremy Yallop)
   #10253
*  repl: allow autocompletion for scoped packages (Evan Lucas)
   #10296
MylesBorins added a commit that referenced this pull request Feb 22, 2017
@MylesBorins
Working on v6.10.1
ee10f21 
PR-URL: #10974
@MylesBorins MylesBorins merged commit 1b6fd44 into v6.x Feb 22, 2017
MylesBorins added a commit that referenced this pull request Feb 22, 2017
@MylesBorins
2017-02-21, Version 6.10.0 'Boron' (LTS)
aecb085 
Notable Changes:

The SEMVER-MINOR changes include:

*  crypto: allow adding extra certs to well-known CAs (Sam Roberts)
   #9139
*  deps: Upgrade INTL ICU to version 58 (Steven R. Loomis)
   #9234
*  process: add `process.memoryUsage.external` (Fedor Indutny)
   #9587
*  src: add wrapper for process.emitWarning() (Sam Roberts)
   #9139

Notable SEMVER-PATCH changes include:

*  fs: cache non-symlinks in realpathSync. (Jeremy Yallop)
   #10253
*  repl: allow autocompletion for scoped packages (Evan Lucas)
   #10296

PR-URL: #10974
@MylesBorins MylesBorins mentioned this pull request Feb 22, 2017
Merged
@sam-github
Copy link
Contributor

@MylesBorins can v6.10.0-proposal be deleted now? @evanlucas (unless I misremember) said that was the intention

@addaleax
Copy link
Member

addaleax commented Mar 6, 2017

@sam-github I’ve seen other collaborators clean up and delete the proposal branches, and nobody complained, so I think that’s okay. 😄

@addaleax addaleax deleted the v6.10.0-proposal branch March 6, 2017 16:54
@sam-github
Copy link
Contributor

I cleaned up the others as well.

@MylesBorins
Copy link
Contributor Author

totally reasonable to clean those up whenever... more often than not they have been cleaned up by other folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.