Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,node-gyp: make delay-load hook optional #1266

Closed
wants to merge 1 commit into from

Commits on Mar 26, 2015

  1. win,node-gyp: make delay-load hook optional

    The delay-load hook that was supposed to make compiled addons work on
    Windows regardless of the iojs.exe/node.exe filename causes issues with
    a small amount of compiled addons.
    
    Therefore this patch makes it an opt-in feature. An addon may set the
    'win_delay_load_hook' option to 'true' in its binding.gyp to enable this
    feature.
    
    Example:
    
    ```
    {
      'targets': [
        {
          'target_name': 'ernie',
          'win_delay_load_hook': 'true',
          ...
    ```
    piscisaureus committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    facd343 View commit details
    Browse the repository at this point in the history