Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix race in parallel/test-vm-debug-context #1294

Merged
merged 1 commit into from
Mar 29, 2015

Commits on Mar 29, 2015

  1. test: fix race in parallel/test-vm-debug-context

    Fix a race condition in parallel/test-vm-debug-context where the 'exit'
    event for the child process is emitted before the first and only 'data'
    event for the child process's stderr stream.
    
    I considered deferring the 'exit' event in lib/child_process.js until
    all stdio streams have been closed but I realized that's not going to
    work when the child process spins off grandchildren that keep the stdio
    file descriptors alive.
    
    Fixes: nodejs#1291
    PR-URL: nodejs#1294
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    bnoordhuis committed Mar 29, 2015
    Configuration menu
    Copy the full SHA
    8d1c87e View commit details
    Browse the repository at this point in the history