Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: fix Promises with later enabled hooks #13242

Closed
wants to merge 6 commits into from
Closed

async_hooks: fix Promises with later enabled hooks #13242

wants to merge 6 commits into from

Commits on May 27, 2017

  1. async_wrap,src: wrap promises directly 

    Promises do not have any internal fields by default. V8 recently added
the capability of configuring the number of internal fields on promises.
This change adds an internal field to promises allowing promises to be
wrapped directly by the PromiseWrap object. In addition to cleaner code
this avoids an extra object allocation per promise and speeds up promise
creation with async_hooks enabled by ~2x.
    @addaleax
    Matt Loring authored and addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    244462b View commit details
    Browse the repository at this point in the history

  2. [squash] close memory leak

    @addaleax
    addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    7f444ff View commit details
    Browse the repository at this point in the history

  3. async_hooks: fix Promises with later enabled hooks 

    Assign a `PromiseWrap` instance to Promises that do not have one
yet when the PromiseHook is being called.

Fixes: nodejs#13237
    @addaleax
    addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    029b68f View commit details
    Browse the repository at this point in the history

  4. [squash] do not emit init event

    @addaleax
    addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    af444fc View commit details
    Browse the repository at this point in the history

  5. [squash] address AndreasMadsen comment

    @addaleax
    addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    55f1b33 View commit details
    Browse the repository at this point in the history

  6. [squash] fix compiler warning

    @addaleax
    addaleax committed May 27, 2017
    Configuration menu
    Copy the full SHA
    0f4e9da View commit details
    Browse the repository at this point in the history