test: fix test-cluster-send-handle-large-payload #14780
Conversation
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess Fixes: nodejs#14747
Trott
added
cluster
|
@nodejs/platform-macos @addaleax @matthewloring @bnoordhuis @cjihrig @mcollina |
|
CI is green. Stress test for current master (shows errors): https://ci.nodejs.org/job/node-stress-single-test/1372/nodes=osx1010/ Stress test for this pull request (green!): https://ci.nodejs.org/job/node-stress-single-test/1371/nodes=osx1010/ |
|
LGTM but I would really kind of prefer to figure out why this is failing … |
Would a |
|
@Trott I think either would be helpful, and being able to compare both kinds even more so. ;) |
|
@addaleax Using current master: Success: https://gist.github.com/Trott/e32e1a48c84a9fdba09177e90bda05d4 Failure: https://gist.github.com/Trott/fb77e052ff369e33d1b18f5ad9492ba9 (terminated with cntl-c after it hung for a while, if that matters) |
|
Landed in 28a47aa |
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess PR-URL: nodejs#14780 Fixes: nodejs#14747 Reviewed-By: Anna Henningsen <anna@addaleax.net>
On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess PR-URL: #14780 Fixes: #14747 Reviewed-By: Anna Henningsen <anna@addaleax.net>
On macOS, the parent process might not receive a message if it
is sent to soon, and then subsequent messages are also sometimes not
received.
(Is this a bug or expected operating system behavior like the
way a file watcher is returned before it's actually watching the file
system on/ macOS?)
Send a second message after a delay on macOS.
While at it, minor refactoring to the test:
commonmodule per test-writing guideFixes: #14747
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster