Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: rewrite inspector test helper #14797

Merged
merged 0 commits into from
Aug 15, 2017
Merged

inspector: rewrite inspector test helper #14797

merged 0 commits into from
Aug 15, 2017

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 13, 2017

Helper was rewritten to rely on promises instead of manually written
queue and callbacks. This simplifies the code and makes it easier to
maintain and extend.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test: inspector tests were rewritten

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Aug 13, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 13, 2017

This is second attempt at landing this change. First PR was landed by mistake and has been rolled back.

The only change between this version and the first one is handling for '\r' in console messages on Windows.

Previous PR link: #14460
CI: https://ci.nodejs.org/job/node-test-pull-request/9635/

@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 13, 2017

The only CI failure is caused by the Git fetch failure on the build bot. Other ARM Linux buildbots were successful.

@eugeneo eugeneo closed this Aug 15, 2017
@eugeneo eugeneo merged commit 5f31d54 into nodejs:master Aug 15, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 15, 2017

Landed as 5f31d54

@eugeneo eugeneo deleted the restore-tests branch August 15, 2017 16:34
@bajtos bajtos mentioned this pull request Aug 16, 2017
4 tasks
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
Helper was rewritten to rely on promises instead of manually written
queue and callbacks. This simplifies the code and makes it easier to
maintain and extend.

PR-URL: #14797
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
Helper was rewritten to rely on promises instead of manually written
queue and callbacks. This simplifies the code and makes it easier to
maintain and extend.

PR-URL: #14797
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
Helper was rewritten to rely on promises instead of manually written
queue and callbacks. This simplifies the code and makes it easier to
maintain and extend.

PR-URL: #14797
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants