Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: implement minimal console.group() #14910

Closed
wants to merge 4 commits into from
Closed

console: implement minimal console.group() #14910

wants to merge 4 commits into from

Commits on Aug 22, 2017

  1. console: implement minimal console.group() 

    Node.js exposes `console.group()` and `console.groupEnd()` via the
inspector. These functions have no apparent effect when called from
Node.js without the inspector. We cannot easily hide them when Node.js
is started without the inspector because we support opening the
inspector during runtime via `inspector.port()`.

Implement a minimal `console.group()`/`console.groupEnd()`. More
sophisticated implementations are possible, but they can be done in
userland and/or features can be added to this at a later time. (It lacks
the `label` argument to `console.group()` right now, for example. How to
handle `label`, or even whether to handle it,  may become
a bikeshed discussion. Landing a minimal implementation first avoids the
pitfall of that discussion or a similar discussion delaying the
implementation indefinitely.)

Refs: nodejs#12675
Fixes: nodejs#1716
    @Trott
    Trott committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    67516e1 View commit details
    Browse the repository at this point in the history

  2. console: add label feature for group()

    @Trott
    Trott committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    e5bbcd2 View commit details
    Browse the repository at this point in the history

  3. console: add groupCollapsed()

    @Trott
    Trott committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    c1d5bcc View commit details
    Browse the repository at this point in the history

  4. squash: groupIndent -> kgroupIndent

    @Trott
    Trott committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    667be1a View commit details
    Browse the repository at this point in the history