Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix wrong history entry in deepStrictEqual #15381

Closed
wants to merge 1 commit into from
Closed

doc: fix wrong history entry in deepStrictEqual #15381

wants to merge 1 commit into from

Conversation

hisener
Copy link
Contributor

@hisener hisener commented Sep 13, 2017

Fixes: #15379

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

None

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 13, 2017
BridgeAR
BridgeAR requested changes Sep 13, 2017
View reviewed changes
doc/api/assert.md Outdated
@@ -109,13 +109,11 @@ parameter is an instance of an `Error` then it will be thrown instead of the
<!-- YAML
added: v1.2.0
changes:
- version: REPLACEME
- version: v8.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept as REPLACEME because it is a semver-major change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jasnell pushed a commit that referenced this pull request Sep 15, 2017
@hisener @jasnell
doc: fix wrong history entry in deepStrictEqual
a591610 
PR-URL: #15381
Fixes: #15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member

jasnell commented Sep 15, 2017

Landed in a591610

@jasnell jasnell closed this Sep 15, 2017
@hisener hisener deleted the fix-assert-api-doc branch September 15, 2017 17:29
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@hisener @addaleax
doc: fix wrong history entry in deepStrictEqual
b6b6484 
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@hisener
doc: fix wrong history entry in deepStrictEqual
bf57bc6 
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc - wrong history entry
6 participants
@hisener @jasnell @lpinca @BridgeAR @MylesBorins @nodejs-github-bot