Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_wrap: Unlink TLSWrap and SecureContext objects asap. #1580

Closed
wants to merge 1 commit into from
Closed

tls_wrap: Unlink TLSWrap and SecureContext objects asap. #1580

wants to merge 1 commit into from

Commits on May 4, 2015

  1. tls_wrap: Unlink TLSWrap and SecureContext objects 

    This makes `TLSWrap` and `SecureContext` objects collectable by the
incremental gc.

`res = null` destroys the cyclic reference in the `reading` property.
`this.ssl = null` removes the remaining reference to the `TLSWrap`.
`this.ssl._secureContext.context = null` removes the reference to
the `SecureContext` object, even though there might be references
to `this.ssl._secureContext` somewhere.

The `reading` property will now throw an error if accessed after the
socket is closed, but that should not happen.
    @ChALkeR
    ChALkeR committed May 4, 2015
    Configuration menu
    Copy the full SHA
    9ab8f9d View commit details
    Browse the repository at this point in the history