test: replace common.fixturesDir with usage of common.fixtures #15893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead
watilde
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
BridgeAR
approved these changes
Oct 9, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: #15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in c11a30d Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: #15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: nodejs/node#15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: #15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: #15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
`test/parallel/test-tls-ecdh.js` was loading fixture keys using `common.fixturesDir`. Now it's using `fixtures.readKey` instead. PR-URL: #15893 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-tls-ecdh.jswas loading fixture keys usingcommon.fixturesDir. Now it's usingfixtures.readKeyinsteadChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test