Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, win: remove note about resize #16320

Closed
wants to merge 1 commit into from
Closed

doc, win: remove note about resize #16320

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Oct 19, 2017

Libuv 1.15.0 improved console resize detection on Windows (libuv/libuv#1408). This note is no longer needed.

Checklist
Affected core subsystem(s)

docs

@bzoz
doc, win: remove note about resize
81f70ea 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.
@bzoz bzoz added the doc Issues and PRs related to the documentations. label Oct 19, 2017
@nodejs-github-bot nodejs-github-bot added the tty Issues and PRs related to the tty subsystem. label Oct 19, 2017
@bzoz
Copy link
Contributor Author

bzoz commented Oct 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10855/

benjamingr
benjamingr approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@refack refack added the windows Issues and PRs related to the Windows platform. label Oct 19, 2017
@bzoz
Copy link
Contributor Author

bzoz commented Oct 26, 2017

Landed in 33021ba

@bzoz bzoz closed this Oct 26, 2017
bzoz added a commit that referenced this pull request Oct 26, 2017
@bzoz
doc, win: remove note about resize
33021ba 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@bzoz @addaleax
doc, win: remove note about resize
5f88e06 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: nodejs/node#16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bzoz @gibfahn
doc, win: remove note about resize
d196740 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bzoz @gibfahn
doc, win: remove note about resize
e1bef37 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@bzoz @gibfahn
doc, win: remove note about resize
fe5d453 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@bzoz @MylesBorins
doc, win: remove note about resize
5389ec6 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@bzoz @MylesBorins
doc, win: remove note about resize
d7d43ad 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@bzoz @MylesBorins
doc, win: remove note about resize
c64ed97 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: #16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@bzoz @addaleax
doc, win: remove note about resize
2b891a7 
Libuv 1.15.0 improved console resize detection on Windows. This note is
no longer needed.

PR-URL: nodejs/node#16320
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tty Issues and PRs related to the tty subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bzoz @refack @jasnell @Fishrock123 @benjamingr @lpinca @cjihrig @MylesBorins @nodejs-github-bot