test: remove common.PORT from parallel tests #17410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
maclover7
approved these changes
Dec 1, 2017
mscdex
reviewed
Dec 1, 2017
| @@ -38,7 +38,7 @@ const { | |||
|
|
|||
| const client = net.connect({ | |||
| host: addresses.INVALID_HOST, | |||
| port: common.PORT, | |||
| port: 80, // port number doesn't matter because hosst name is invalid | |||
There was a problem hiding this comment.
Typo in comment.
It might be a good idea to add a common.mustNotCall() for the 'connect' event.
cjihrig
approved these changes
Dec 1, 2017
lance
approved these changes
Dec 1, 2017
lpinca
approved these changes
Dec 1, 2017
hiroppy
approved these changes
Dec 2, 2017
`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI.
Trott
force-pushed
the
no-port-in-parallel
branch
from
a691006
to
9062864
Compare
|
Nits addressed. (Thanks, @mscdex!) |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2017
`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI. PR-URL: nodejs#17410 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in e183900 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI. PR-URL: #17410 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI. PR-URL: #17410 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
|
Should land cleanly once #17296 lands |
gibfahn
pushed a commit
that referenced
this pull request
Apr 12, 2018
`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI. PR-URL: #17410 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
@MylesBorins I've just landed this on v8.x-staging (conflicts were resolved due to @joyeecheung 's backport of #17296). This fixes test failures like: not ok 1781 async-hooks/test-graph.tcp
---
duration_ms: 0.682
severity: fail
stack: |-
/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/async-hooks/test-graph.tcp.js:20
net.connect({ port: server.address().port, host: '::1' },
^
TypeError: Cannot read property 'port' of null
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/async-hooks/test-graph.tcp.js:20:37)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:184:16)
at bootstrap_node.js:605:3
...
ok 1782 async-hooks/test-embedder.api.async-resource.improper-order
---
duration_ms: 1.155
...So if you start seeing those you may want to prioritise getting this landed on 6.x. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.PORTshould not be used in parallel tests because another testmay experience a collision with
common.PORTwhen using port 0 to getan open port. This has been observed to result in test failures in CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test