-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix man pages link to signal #17725
Conversation
This add the space needed to match the man pages linking regex. Refs: nodejs#17724
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd greatly prefer to fix the regular expression rather than force white space changes that really ought to have no effect.
@Trott I agree with you, the regex must be fixed. Anyhow, this PR improves readability of that paragraph. |
Closing since #17724 was landed and fixed original issue. Please reopen if still needed. |
@maclover7 I would still merge this. As I said before, it improves readability of that paragraph. |
I'm unconvinced that this is an improvement. I don't think this substantially improves readability, and it introduces an idiosyncratic line-wrapping that (AFAIK) we don't do anywhere else. (Docs are wrapped at 80 chars, not one-line-per-sentence.) (That said, I'm stoked that the regexp was improved in the related PR!) |
Alright :) |
This add the space needed to match the man pages linking regex.
Refs: #17724
Checklist
Affected core subsystem(s)
doc