Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix man pages link to signal #17725

Closed
wants to merge 2 commits into from

Conversation

DiegoRBaquero
Copy link
Contributor

This add the space needed to match the man pages linking regex.

Refs: #17724

Checklist
Affected core subsystem(s)

doc

This add the space needed to match the man pages linking regex.

Refs: nodejs#17724
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Dec 18, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd greatly prefer to fix the regular expression rather than force white space changes that really ought to have no effect.

@DiegoRBaquero
Copy link
Contributor Author

@Trott I agree with you, the regex must be fixed.

Anyhow, this PR improves readability of that paragraph.

@maclover7
Copy link
Contributor

Closing since #17724 was landed and fixed original issue. Please reopen if still needed.

@maclover7 maclover7 closed this Dec 22, 2017
@DiegoRBaquero
Copy link
Contributor Author

@maclover7 I would still merge this. As I said before, it improves readability of that paragraph.

@maclover7 maclover7 reopened this Dec 24, 2017
@Trott
Copy link
Member

Trott commented Dec 24, 2017

I'm unconvinced that this is an improvement. I don't think this substantially improves readability, and it introduces an idiosyncratic line-wrapping that (AFAIK) we don't do anywhere else. (Docs are wrapped at 80 chars, not one-line-per-sentence.)

(That said, I'm stoked that the regexp was improved in the related PR!)

@DiegoRBaquero
Copy link
Contributor Author

Alright :)

@DiegoRBaquero DiegoRBaquero deleted the patch-2 branch December 24, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants