tools: alphabetize ESLint rules #19100
Conversation
Trott
force-pushed
the
reorder-eslint-props
branch
from
260c79f
to
6329881
Compare
|
cc @nodejs/linting |
| 'dot-location': ['error', 'property'], | ||
| 'dot-notation': 'error', | ||
| 'eol-last': 'error', | ||
| eqeqeq: ['error', 'smart'], |
There was a problem hiding this comment.
Is there a reason some of these are ' quoted and others not? If not, can we pick one style and be consistent?
There was a problem hiding this comment.
I definitely prefer it be consistent and intend to introduce a lint rule requiring that (if someone doesn't beat me to it). Was going to wait for this to land first to keep the pull requests minimal and focused. By waiting for this to land first, we avoid a merge conflict.
There was a problem hiding this comment.
I'm guessing they're quoted as needed for object properties.
There was a problem hiding this comment.
Yeah, I don't like that and would prefer that they all be quoted for consistency if one needs to be quoted. But that's just a preference. My plan is to try to figure out what the most common practice is in the code base, and then enforce that. If it's what's going on here, then so be it.
Editing error? (PR description and commit message). |
Yup. Fixing right now. Thanks. |
I have never found it useful that the ESLint rules (in the configuration file) are organized by the categorization the rules are given in the ESLint documentation. It has only been a source of annoyance as one has to look up where the rule is in the docs to figure out where it should go in the configuration file. This change re-orders the rules so they are in alphabetical order. Simple!
Trott
force-pushed
the
reorder-eslint-props
branch
from
6329881
to
cbca4e2
Compare
| 'dot-location': ['error', 'property'], | ||
| 'dot-notation': 'error', | ||
| 'eol-last': 'error', | ||
| eqeqeq: ['error', 'smart'], |
There was a problem hiding this comment.
I'm guessing they're quoted as needed for object properties.
|
(CI failures appear build-related and not related to this change...I mean, that's probably obvious. If the linter passed, I think we're good here.) |
Trott
added
the
author ready
|
Landed in c221355 |
Trott
removed
the
author ready
I have never found it useful that the ESLint rules (in the configuration file) are organized by the categorization the rules are given in the ESLint documentation. It has only been a source of annoyance as one has to look up where the rule is in the docs to figure out where it should go in the configuration file. This change re-orders the rules so they are in alphabetical order. Simple! PR-URL: #19100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this be backported to |
Refs: nodejs#19100 (comment) PR-URL: nodejs#19156 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Roman Reiss <me@silverwind.io>
I have never found it useful that the ESLint rules (in the configuration file) are organized by the categorization the rules are given in the ESLint documentation. It has only been a source of annoyance as one has to look up where the rule is in the docs to figure out where it should go in the configuration file. This change re-orders the rules so they are in alphabetical order. Simple! PR-URL: nodejs#19100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs#19100 (comment) PR-URL: nodejs#19156 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Roman Reiss <me@silverwind.io>
I have never found it useful that the ESLint rules (in the
configuration file) are organized by the categorization the rules are
given in the ESLint documentation. It has only been a source of
annoyance as one has to look up where the rule is in the docs to figure
out where it should go in the configuration file.
This change re-orders the rules so they are in alphabetical order.
Simple!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools