Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x-backport] test: add assertions for TextEncoder/Decoder #19358

Closed
wants to merge 1 commit into from
Closed

[v8.x-backport] test: add assertions for TextEncoder/Decoder #19358

wants to merge 1 commit into from

Conversation

lance
Copy link
Member

@lance lance commented Mar 14, 2018

PR-URL: #18132
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Tiancheng "Timothy" Gu timothygu99@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@lance
test: add assertions for TextEncoder/Decoder
6f54c46 
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Mar 14, 2018
@lance lance mentioned this pull request Mar 14, 2018
Closed
3 tasks
@lance
Copy link
Member Author

lance commented Mar 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13684/

@gibfahn gibfahn self-assigned this Mar 15, 2018
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
a618966 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

landed in a618966

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
88e0f23 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
e42ab10 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gibfahn gibfahn

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance @MylesBorins @gibfahn @nodejs-github-bot