Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing crypto checks #2129

Closed

Conversation

jbergstroem
Copy link
Member

Add a check for crypto before using it, similar to how other tests work.

Guess my previous commit ("Refactor all tests that depends on crypto", 671fbd5) wasn't accurate 🐼

/R=@shigeki? (you reviewed last time)

Add a check for crypto before using it, similar to how
other tests work.
@shigeki
Copy link
Contributor

shigeki commented Jul 8, 2015

I wrote these tests and missed to add the checks. Thanks for catching. LGTM.

@Fishrock123
Copy link
Contributor

LGTM

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Jul 8, 2015
jbergstroem added a commit that referenced this pull request Jul 8, 2015
Add a check for crypto before using it, similar to how
other tests work.

PR-URL: #2129
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jbergstroem
Copy link
Member Author

Merged in 2ba1740. Thanks for the review.

@jbergstroem jbergstroem closed this Jul 8, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Add a check for crypto before using it, similar to how
other tests work.

PR-URL: nodejs#2129
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants