Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] test: add http _dump regression test #21595

Closed
wants to merge 1 commit into from
Closed

[v8.x] test: add http _dump regression test #21595

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Test part of 299da1f, specifically for v8.x.

@addaleax
test: add http _dump regression test
a2a5398 
Test part of 299da1f, specifically for v8.x.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/178/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Jun 29, 2018
@addaleax addaleax changed the title test: add http _dump regression test [v8.x] test: add http _dump regression test Jun 29, 2018
@addaleax addaleax added the http Issues or PRs related to the http subsystem. label Jun 29, 2018
@addaleax addaleax mentioned this pull request Jun 29, 2018
Closed
3 tasks
@addaleax
Copy link
Member Author

Only test failure in the automated run is a known flake, being tracked at #21188

Can somebody give this a quick LGTM? It’s a clean copy of the original test, so it’s enough to hear an approval in the sense of an enthusiastic ”yes let’s add a test that contains already-reviewed code”

@addaleax
Copy link
Member Author

Landed in 5b64d26

@addaleax addaleax closed this Jul 11, 2018
addaleax added a commit that referenced this pull request Jul 11, 2018
@addaleax
test: add http _dump regression test
5b64d26 
Test part of 299da1f, specifically for v8.x.

PR-URL: #21595
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax deleted the backport-20088-test branch July 11, 2018 16:49
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
test: add http _dump regression test
0f45ecb 
Test part of 299da1f, specifically for v8.x.

PR-URL: #21595
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @apapirovski @lpinca