Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: make _toBuf non-enumerable #22551

Closed
wants to merge 1 commit into from
Closed

crypto: make _toBuf non-enumerable #22551

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

After landing #22501, I noticed that I did not make _toBuf non-enumerable. Following the discussion in #22519, I believe it should be, so here is that. Partially also for consistency with the rest of crypto.js.

cc @nodejs/crypto

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 27, 2018
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/696/pipeline

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Aug 27, 2018
@tniessen
Copy link
Member Author

tniessen commented Aug 27, 2018 •
edited
Loading

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16787/
Resumed in: https://ci.nodejs.org/job/node-test-pull-request/16872/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
addaleax
addaleax approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this depends on a semver-major change, so it doesn’t really matter, but I don’t think we need to consider this one.

@tniessen
Copy link
Member Author

@addaleax I thought we considered such changes as semver-major themselves, I am not sure though.

@tniessen
Copy link
Member Author

Landed in 503fd55.

@tniessen tniessen closed this Aug 30, 2018
tniessen added a commit that referenced this pull request Aug 30, 2018
@tniessen
crypto: make _toBuf non-enumerable
503fd55 
PR-URL: #22551
Refs: #22501
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @jasnell @thefourtheye @addaleax @cjihrig @trivikr