Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use maybe version v8::Function::Call #23826

Closed
wants to merge 1 commit into from
Closed

src: use maybe version v8::Function::Call #23826

wants to merge 1 commit into from

Conversation

oyyd
Copy link
Contributor

@oyyd oyyd commented Oct 23, 2018

Refs: #23804

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 23, 2018
@lundibundi
Copy link
Member

Original CI: https://ci.nodejs.org/job/node-test-pull-request/18068/

known flake failed (fix #23811)

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18071/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2018
@refack
Copy link
Contributor

refack commented Oct 23, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18082/ ✔️

@addaleax
Copy link
Member

addaleax commented Oct 25, 2018 •
edited
Loading

Landed in d8924a0 🎉

@addaleax addaleax closed this Oct 25, 2018
addaleax pushed a commit that referenced this pull request Oct 25, 2018
@oyyd @addaleax
src: use maybe version v8::Function::Call
d8924a0 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 26, 2018
@oyyd @targos
src: use maybe version v8::Function::Call
02d83d4 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 27, 2018
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
@oyyd @targos
src: use maybe version v8::Function::Call
ce106df 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BethGriggs pushed a commit that referenced this pull request Oct 18, 2019
@oyyd @BethGriggs
src: use maybe version v8::Function::Call
18b140a 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mmarchini mmarchini mmarchini approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@oyyd @lundibundi @refack @addaleax @MylesBorins @jasnell @cjihrig @mmarchini @BethGriggs @nodejs-github-bot