Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cache the result of GetOptions() in JS land #24091

Closed
wants to merge 2 commits into from
Closed

src: cache the result of GetOptions() in JS land #24091

wants to merge 2 commits into from

Commits on Nov 4, 2018

  1. src: cache the result of GetOptions() in JS land 

    Instead of calling into C++ each time we need to check the value
of a command line option, cache the option map in a new
`internal/options` module for faster access to the values in JS land.
    @joyeecheung
    joyeecheung committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    22446f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. fixup! src: cache the result of GetOptions() in JS land

    @joyeecheung
    joyeecheung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    977cb18 View commit details
    Browse the repository at this point in the history